OpenStack Compute (nova)

resize broken when not allowing same host

Bug #1034593 reported by Chris Behrens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Chris Behrens
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

Recent cleanups in scheduler related to passing full instances caused this to be added to schedule_prep_resize:

125 updated_instance = driver.instance_update_db(context, instance['uuid '],
126 host.host_state.host)

prep_resize should NOT update instance['host'] in the scheduler.. else the check inside of prep_resize() in compute manager comparing instance['host'] against FLAGS.host will always succeed. instance['host'] should be the current (source) host.

Chris Behrens (cbehrens)
Changed in nova:
importance: Undecided → Critical
assignee: nobody → Chris Behrens (cbehrens)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11054

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11054
Committed: http://github.com/openstack/nova/commit/10a5f1ac025f89f84398be308455b72d77602cc3
Submitter: Jenkins
Branch: master

commit 10a5f1ac025f89f84398be308455b72d77602cc3
Author: Chris Behrens <email address hidden>
Date: Wed Aug 8 21:09:14 2012 +0000

    scheduler prep_resize should not update instance['host']

    This is done by the manager once things are ready on the destination
    compute node.

    Fixes bug 1034593

    Also removes now-unneeded update_db argument passed via rpcapi and bumps
    scheduler rpcapi version for prep_resize to 1.4

    Change-Id: I0ac3be39877f3afcf42f5996d0da90042fe7c6e3

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.