Ubuntu One Control Panel

Replace simplejson with json

Bug #1029094 reported by Barry Warsaw
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Status tracked in Trunk
Stable-4-2
Fix Released
Undecided
Unassigned
Ubuntu One Client 4.1.90
Trunk
Fix Released
Undecided
dobey
Ubuntu One Control Panel
Status tracked in Trunk
Stable-4-2
Fix Released
Undecided
Unassigned
Ubuntu One Control Panel 4.1.0
Trunk
Fix Released
Undecided
Barry Warsaw
ubuntuone-client (Ubuntu)
Fix Released
Medium
dobey
Raring
Fix Released
Medium
dobey
ubuntuone-control-panel (Ubuntu)
Fix Released
Undecided
Unassigned
Raring
Fix Released
Undecided
Unassigned

Bug Description

In preparation for porting to Python 3, ubuntuone-control-panel should use the standard library `json` module instead of the third party `simplejson` module. The latter is not ported to Python 3, but it is also unnecessary now that there is a stdlib version. This change is appropriate for Python 2.6 and 2.7 as well.

I will attach a branch momentarily.

Tags: u1-notrack

Related branches

lp://staging/~barry/ubuntuone-control-panel/use-json
dobey (community): Approve
Diff: 49 lines (+4/-5)
2 files modified
ubuntuone/controlpanel/tests/test_backend.py (+2/-3)
ubuntuone/controlpanel/web_client.py (+2/-2)
lp://staging/ubuntu/raring/ubuntuone-control-panel
lp://staging/~dobey/ubuntuone-client/no-simplejson
Michał Karnicki (community): Approve
Roberto Alsina (community): Approve
Diff: 30 lines (+3/-3)
1 file modified
ubuntuone/syncdaemon/action_queue.py (+3/-3)
lp://staging/ubuntu/raring/ubuntuone-client
Revision history for this message
Barry Warsaw (barry) wrote :

I'll also note that this package is the last one that uses simplejson on the Ubuntu desktop images. By making this change it will allow us to drop simplejson as a Python 3 porting dependency.

Revision history for this message
Barry Warsaw (barry) wrote :

Merge proposed.

dobey (dobey)
Changed in ubuntuone-control-panel (Ubuntu Raring):
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 4.1.0-0ubuntu1

---------------
ubuntuone-control-panel (4.1.0-0ubuntu1) raring; urgency=low

  * New upstream release.
    - Replace simplejson usage with json. (LP: #1029094)
    - Clear search when clicking (X) icon in search entry. (LP: #1070917)
    - Raise existing window if process already running. (LP: #1063927)
    - Don't auto-publish when selecting a search result. (LP: #1065194)
    - Add a new .desktop file for the GNOME-only remix of Ubuntu.
  * debian/control:
    - Switch pylint build dependency to pyflakes.
    - Remove python-simplejson from dependencies.
  * debian/ubuntuone-control-panel-qt.install:
    - Add new .desktop file for GNOME remix.
    - Remove the messaging menu integration file.
  * debian/watch:
    - Update to use stable-4-2 series for Ubuntu 13.04 releases.
 -- Rodney Dawes <email address hidden> Mon, 10 Dec 2012 09:56:24 -0500

Changed in ubuntuone-control-panel (Ubuntu Raring):
status: Triaged → Fix Released
dobey (dobey)
Changed in ubuntuone-client (Ubuntu Raring):
assignee: nobody → Rodney Dawes (dobey)
importance: Undecided → Medium
status: New → Triaged
Julien Funk (jaboing)
tags: added: u1-notrack
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 4.1.90-0ubuntu1

---------------
ubuntuone-client (4.1.90-0ubuntu1) raring; urgency=low

  * New upstream release.
    - Fix support for searching local files in cloud folders. (LP: #1101271)
    - Various fixes to the test suite.
    - Fix tritcask DataFile.write to flush with new libc6. (LP: #1093111)
    - Remove most of the static glib bindings usage. (LP: #1108036)
    - Avoid g_type_init with new versions of glib. (LP: #1100926)
    - Replace simplejson usage with json. (LP: #1029094)
    - Use a standard LC_CTYPE locale when the LANG is turkish. (LP: #997326)
  * debian/control:
    - Require newer version of ubuntu-sso-client for LANG fix.
    - Update dependencies to drop fallbacks for static bindings.
 -- Rodney Dawes <email address hidden> Tue, 29 Jan 2013 15:22:08 -0500

Changed in ubuntuone-client (Ubuntu Raring):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.