Not creating a client in a ServerTestCase results in dirty reactor error
Bug #1002834 reported by
Manuel de la Peña
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| ubuntuone-dev-tools | Status tracked in Trunk | |||||
| Stable-4-0 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Medium
|
Manuel de la Peña | |||
| ubuntuone-dev-tools (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | |||
| Quantal |
Fix Released
|
Undecided
|
Unassigned | |||
Bug Description
The ServerTestCase provides a way to run a a single tidy server for tests. Unfrotunatly if the tests do not create a client the cleanUp added by the super calss does not correctly clean the server resulting in a dirty reactor error.
Related branches
lp://staging/~mandel/ubuntuone-dev-tools/correct-cleanup
- Eric Casteleijn (community): Approve
- Diego Sarmentero (community): Approve
-
Diff: 14 lines (+2/-1)1 file modifiedubuntuone/devtools/testcases/txsocketserver.py (+2/-1)
| Changed in ubuntuone-dev-tools: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntuone-dev-tools (Ubuntu Quantal): | |
| status: | New → Triaged |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntuone-dev-tools (Ubuntu Quantal): | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntuone-dev-tools - 3.99.0-0ubuntu1
---------------
ubuntuone-dev-tools (3.99.0-0ubuntu1) quantal; urgency=low
* New upstream release.
- Expose squid startup errors when it fails. (LP: #985004)
- Default to gi/gtk3 reactors and fallback to glib/gtk2 on Linux.
- Allow using domain sockets instead of TCP in tests. (LP: #988257)
- Clean up ServerTestCase properly to avoid dirty reactor. (LP: #1002834)
* debian/watch:
- Update watch file to use stable-4-0 series for Quantal.
-- Rodney Dawes <email address hidden> Tue, 05 Jun 2012 13:17:20 -0400