OpenStack Compute (nova)

nova-novncproxy need to change to supporting new flag file utils

Bug #1001098 reported by Edward
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Jake Dahn
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

nova-novncproxy need to change to supporting new flag file nova.utils module

cd /opt/stack/noVNC && ./utils/nova-novncproxy --config-file /etc/nova/nova.conf --web .
Traceback (most recent call last):
  File "./utils/nova-novncproxy", line 130, in <module>
    utils.default_flagfile()
AttributeError: 'module' object has no attribute 'default_flagfile'

Change to-do: utils.default_flagfile() to util.default_cfgfile()

Edward (zhang-hare)
Changed in nova:
assignee: nobody → Edward (zhang-hare)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7574

Changed in nova:
assignee: Edward (zhang-hare) → Anthony Young (sleepsonthefloor)
status: New → In Progress
Edward (zhang-hare)
Changed in nova:
assignee: Anthony Young (sleepsonthefloor) → nobody
Revision history for this message
Anthony Young (sleepsonthefloor) wrote :

Edward - I just proposed adding nova-novncproxy back into nova: https://review.openstack.org/7574 (the fix for this is included in that patch)

For the above program, you will need https://github.com/kanaka/websockify, which replaces the wsproxy dependency in the current proxy. If you have a chance to review it would be much appreciated. Thanks for catching this.

Revision history for this message
Edward (zhang-hare) wrote :

This is not included gerrit. I can't commit it for review.

Edward (zhang-hare)
Changed in nova:
status: In Progress → New
Anthony Young (sleepsonthefloor)
Changed in nova:
assignee: nobody → Anthony Young (sleepsonthefloor)
Devin Carlen (devcamcar)
Changed in nova:
milestone: none → folsom-1
OpenStack Infra (hudson-openstack)
Changed in nova:
status: New → In Progress
Devin Carlen (devcamcar)
Changed in nova:
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-1 → folsom-2
OpenStack Infra (hudson-openstack)
Changed in nova:
assignee: Anthony Young (sleepsonthefloor) → Jake Dahn (jakedahn)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/7574
Committed: http://github.com/openstack/nova/commit/13871ad4f39361531dff1abd7f9257369862cccc
Submitter: Jenkins
Branch: master

commit 13871ad4f39361531dff1abd7f9257369862cccc
Author: Anthony Young <email address hidden>
Date: Thu May 17 23:05:27 2012 -0700

    Propose nova-novncproxy back into nove core.

      * Use https://github.com/kanaka/websockify instead of wsproxy
        (which ships with noVNC)
      * Fixes bug 1001098
      * Looks for noVNC html files in /usr/share/novnc by default
      * Fix comments, and call utils.default_cfgfile()
      * use "except Exception"

    Change-Id: I73dfe26fde699bb79aa1145bb1ab33f3a148bf21

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.