On 23 September 2010 09:15, Craig Hewetson <email address hidden> wrote:
> Context:
> I want to use content filtering to fix the line endings horror. Content filtering only works when a lot of preconditions are met, otherwise it fails silently (simply does not work WITHOUT reporting an error) even though it is configured in .bazaar/rules.
>
> [This by itself is a serious bug in my eyes because it causes silent corruption of the repository (files containing a full delta because their line endings are incorrect). This is quite horrible and cannot really be seen by the developer - he just sees the files he's worked on being committed. Only a long time after this merge will the problem be seen, when another merge is attempted causing a full conflict.]
I think the best way to guard against this sort of thing is to have a
check run on the central server before commit. i.e. install a
plugin[1] on the server that prevents these changes from occurring.
But then you can only allow smartserver access eg. bzr+https://
On 23 September 2010 09:15, Craig Hewetson <email address hidden> wrote:
> Context:
> I want to use content filtering to fix the line endings horror. Content filtering only works when a lot of preconditions are met, otherwise it fails silently (simply does not work WITHOUT reporting an error) even though it is configured in .bazaar/rules.
>
> [This by itself is a serious bug in my eyes because it causes silent corruption of the repository (files containing a full delta because their line endings are incorrect). This is quite horrible and cannot really be seen by the developer - he just sees the files he's worked on being committed. Only a long time after this merge will the problem be seen, when another merge is attempted causing a full conflict.]
I think the best way to guard against this sort of thing is to have a
check run on the central server before commit. i.e. install a
plugin[1] on the server that prevents these changes from occurring.
But then you can only allow smartserver access eg. bzr+https://
[1] I wrote a plugin that can do similar checks, if you like I can /launchpad. net/bzr- text-checker
extend it to be able to check line endings:
https:/