Breezy

Bug #1849971
Comment #4

Comment 4 for bug 1849971

Revision history for this message

Jelmer Vernooij (jelmer) wrote on 2019-10-26: Re: [Bug 1849971] Re: Some tests failing due to shutdown(2) returning EINVAL

On Sat, Oct 26, 2019 at 06:12:40PM -0000, Olaf Seibert wrote:
> I am currently running all tests again, but with the sock.shutdown()
> simply commented out. On first sight, it seems unneeded just before
> close(). The test results look much better now. I'm down to 2 errors and
> 2 failures, some of those probably because I use a boring old C locale
> instead of UTF-8.
>
> ERROR: breezy.tests.blackbox.test_testament.TestTestament.test_testament_non_ascii
> ...
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 6: ordinal not in range(128)
Please file a new bug about this, with the full backtrace.

>
> ======================================================================
>
> ERROR: unittest.loader._FailedTest.breezy.plugins.launchpad
> breezy.plugins.launchpad.lp_api.LaunchpadlibMissing: launchpadlib is required for Launchpad API access. Please install the launchpadlib package.
launchpadlib is required for the launchpad plugin, but that plugin
should be optional. The tests should simply be skipped if it is
missing.

Can you file a separate bug about this issue as well?

> ======================================================================
> FAIL: breezy.tests.blackbox.test_locale.TestLocale.test_log_BOGUS
> ...
> AssertionError: string b'brz: warning: some compiled extensions could not be loaded; see ``brz help missing-extensions``\n' does not start with b'brz: warning: unsupported locale setting'
> ======================================================================
> FAIL: breezy.tests.test_mail_client.TestClaws.test_commandline_is_8bit
>
>
> How do I find which compiled extensions are failing? Bazaar already reported that as a problem, but I've never seen the root cause of it, so far. I am aware that I don't have the launchpadlib installed (there was no pkgsrc package for it yet, and it seemed to be used only in tools/check-newsbugs.py which is not installed.

The compiled extensions should be optional, none of the tests should
fail if they are missing.

You can build the C extensions (and see which ones fail to build) by
running "make".

Jelmer

--
Jelmer Vernooĳ <email address hidden>
PGP Key: https://www.jelmer.uk/D729A457.asc

On Sat, Oct 26, 2019 at 06:12:40PM -0000, Olaf Seibert wrote:
> I am currently running all tests again, but with the sock.shutdown()
> simply commented out. On first sight, it seems unneeded just before
> close(). The test results look much better now. I'm down to 2 errors and
> 2 failures, some of those probably because I use a boring old C locale
> instead of UTF-8.
> 
> ERROR: breezy.tests.blackbox.test_testament.TestTestament.test_testament_non_ascii
> ...
> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 6: ordinal not in range(128)
Please file a new bug about this, with the full backtrace.

> 
> ======================================================================
> 
> ERROR: unittest.loader._FailedTest.breezy.plugins.launchpad
> breezy.plugins.launchpad.lp_api.LaunchpadlibMissing: launchpadlib is required for Launchpad API access. Please install the launchpadlib package.
launchpadlib is required for the launchpad plugin, but that plugin
should be optional. The tests should simply be skipped if it is
missing.

Can you file a separate bug about this issue as well?

> ======================================================================
> FAIL: breezy.tests.blackbox.test_locale.TestLocale.test_log_BOGUS
> ...
> AssertionError: string b'brz: warning: some compiled extensions could not be loaded; see ``brz help missing-extensions``\n' does not start with b'brz: warning: unsupported locale setting'
> ======================================================================
> FAIL: breezy.tests.test_mail_client.TestClaws.test_commandline_is_8bit
> 
> 
> How do I find which compiled extensions are failing? Bazaar already reported that as a problem, but I've never seen the root cause of it, so far. I am aware that I don't have the launchpadlib installed (there was no pkgsrc package for it yet, and it seemed to be used only in tools/check-newsbugs.py which is not installed.

The compiled extensions should be optional, none of the tests should
fail if they are missing.

You can build the C extensions (and see which ones fail to build) by
running "make".

Jelmer

-- 
Jelmer Vernooĳ <jelmer@jelmer.uk>
PGP Key: https://www.jelmer.uk/D729A457.asc