I had the same idea about multiple shutdowns, but in my test that didn't trigger any exception. I also tried UNIX domain sockets to see if they behaved differently perhaps, but no. At least not in the super simple test below.
I am currently running all tests again, but with the sock.shutdown() simply commented out. On first sight, it seems unneeded just before close(). The test results look much better now. I'm down to 2 errors and 2 failures, some of those probably because I use a boring old C locale instead of UTF-8.
ERROR: breezy.tests.blackbox.test_testament.TestTestament.test_testament_non_ascii
...
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 6: ordinal not in range(128)
ERROR: unittest.loader._FailedTest.breezy.plugins.launchpad
breezy.plugins.launchpad.lp_api.LaunchpadlibMissing: launchpadlib is required for Launchpad API access. Please install the launchpadlib package.
======================================================================
FAIL: breezy.tests.blackbox.test_locale.TestLocale.test_log_BOGUS
...
AssertionError: string b'brz: warning: some compiled extensions could not be loaded; see ``brz help missing-extensions``\n' does not start with b'brz: warning: unsupported locale setting'
======================================================================
FAIL: breezy.tests.test_mail_client.TestClaws.test_commandline_is_8bit
How do I find which compiled extensions are failing? Bazaar already reported that as a problem, but I've never seen the root cause of it, so far. I am aware that I don't have the launchpadlib installed (there was no pkgsrc package for it yet, and it seemed to be used only in tools/check-newsbugs.py which is not installed.
I had the same idea about multiple shutdowns, but in my test that didn't trigger any exception. I also tried UNIX domain sockets to see if they behaved differently perhaps, but no. At least not in the super simple test below.
$ cat sock.py
import socket
s = socket. socket( socket. AF_UNIX, -1, -1, None) socket. SHUT_WR) socket. SHUT_RDWR) socket. SHUT_RDWR) AddressFamily. AF_UNIX, type=SocketKind .SOCK_STREAM, proto=0>
print(s)
s.shutdown(
s.shutdown(
s.shutdown(
$ python3.7 sock.py
<socket.socket fd=3, family=
$
I am currently running all tests again, but with the sock.shutdown() simply commented out. On first sight, it seems unneeded just before close(). The test results look much better now. I'm down to 2 errors and 2 failures, some of those probably because I use a boring old C locale instead of UTF-8.
ERROR: breezy. tests.blackbox. test_testament. TestTestament. test_testament_ non_ascii
...
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 6: ordinal not in range(128)
======= ======= ======= ======= ======= ======= ======= ======= ======= =======
ERROR: unittest. loader. _FailedTest. breezy. plugins. launchpad plugins. launchpad. lp_api. LaunchpadlibMis sing: launchpadlib is required for Launchpad API access. Please install the launchpadlib package. ======= ======= ======= ======= ======= ======= ======= ======= ======= tests.blackbox. test_locale. TestLocale. test_log_ BOGUS extensions` `\n' does not start with b'brz: warning: unsupported locale setting' ======= ======= ======= ======= ======= ======= ======= ======= ======= tests.test_ mail_client. TestClaws. test_commandlin e_is_8bit
breezy.
=======
FAIL: breezy.
...
AssertionError: string b'brz: warning: some compiled extensions could not be loaded; see ``brz help missing-
=======
FAIL: breezy.
How do I find which compiled extensions are failing? Bazaar already reported that as a problem, but I've never seen the root cause of it, so far. I am aware that I don't have the launchpadlib installed (there was no pkgsrc package for it yet, and it seemed to be used only in tools/check- newsbugs. py which is not installed.
-Olaf.