Comment 3 for bug 1849971

Revision history for this message
Olaf Seibert (rhialto) wrote :

I had the same idea about multiple shutdowns, but in my test that didn't trigger any exception. I also tried UNIX domain sockets to see if they behaved differently perhaps, but no. At least not in the super simple test below.

$ cat
import socket

s = socket.socket(socket.AF_UNIX, -1, -1, None)
$ python3.7
<socket.socket fd=3, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0>

I am currently running all tests again, but with the sock.shutdown() simply commented out. On first sight, it seems unneeded just before close(). The test results look much better now. I'm down to 2 errors and 2 failures, some of those probably because I use a boring old C locale instead of UTF-8.

ERROR: breezy.tests.blackbox.test_testament.TestTestament.test_testament_non_ascii
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 6: ordinal not in range(128)


ERROR: unittest.loader._FailedTest.breezy.plugins.launchpad
breezy.plugins.launchpad.lp_api.LaunchpadlibMissing: launchpadlib is required for Launchpad API access. Please install the launchpadlib package.
FAIL: breezy.tests.blackbox.test_locale.TestLocale.test_log_BOGUS
AssertionError: string b'brz: warning: some compiled extensions could not be loaded; see ``brz help missing-extensions``\n' does not start with b'brz: warning: unsupported locale setting'
FAIL: breezy.tests.test_mail_client.TestClaws.test_commandline_is_8bit

How do I find which compiled extensions are failing? Bazaar already reported that as a problem, but I've never seen the root cause of it, so far. I am aware that I don't have the launchpadlib installed (there was no pkgsrc package for it yet, and it seemed to be used only in tools/ which is not installed.