Comment 33 for bug 50437

Revision history for this message
Martin Pitt (pitti) wrote : Re: [Bug 50437] Re: Resume from hibernation may fail because swap partition UUID does not match /etc/initramfs-tools/conf.d/resume

Hey Maximilian,

maximilian attems [2013-09-11 7:57 -0000]:
> > otherwise dynamically create one based on the existing swap partition(s)
> > using the ubiquity logic.
>
> No idea what ubiquity does and what logic you point too, afaik that
> config file was allways in Debian written by initramfs-tools preinst.

Our live filesystems are built in a chroot, and don't contain a
pre-made resume file, so the preinst's "am I in a chroot" logic works.

> Could you point to the relevant ubiquity code, please.

That's

  http://bazaar.launchpad.net/~ubuntu-installer/ubiquity/trunk/view/head:/scripts/plugininstall.py#L883

maximilian attems [2013-09-11 9:56 -0000]:
> On Wed, Sep 11, 2013 at 01:38:26AM -0000, Martin Pitt wrote:
> >
> > I agree. I think *if* /etc/initramfs-tools/conf.d/resume exists and is
> > valid, it should copy that into the initramfs,
>
> ok on second thought this is easy and right, fixed in initramfs-tools.git
> maks/swap branch with 3 commits (might land soonish in master)

Cheers, these look nice. That will avoid the pointless 5 s waiting
during boot. The only issue now is that you can't choose to entirely
disable hibernation by creating an empty file or having no file at
all; not sure how much of an issue that is. Perhaps if the file exists
and is empty that shold indicate "disable resume", and if the file
doesn't exist, "automatic resume"?