Arch Linux
wine package

  1. Bug #913444
  2. Comment #20

Comment 20 for bug 913444

Revision history for this message
In , Gregor Riepl (onitake) wrote :

Thanks for the patch!

A few comments on the code:

                     strcpy(szMyStuffTarget, szPersonalTarget);
                     if (_SHAppendToUnixPath(szMyStuffTarget, MAKEINTRESOURCEW(aidsMyStuff[i])))
- mkdir(szMyStuffTarget, 0777);
+ mkdir(szMyStuffTarget, 0755);

(similar lines follow)

Are you sure that you want to circumvent the umask?
In most environments, the group and owner write bits are masked out anyway, and sometimes users might have set a less restrictive umask. This mode will prevent that, and I don't think it is relevant to the issue anyway.

There seem to be some whitespace issues as well.

And where is _SHCreateSymbolicLinks defined?