Zun

Remove Docker-specific code from manager

Bug #1639333 reported by hongbin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zun
Triaged
Medium
KS Kim

Bug Description

This is for tracking @Pradeep's comment in https://review.openstack.org/#/c/392886/ :

  I have a basic concern, i may be wrong,
  1) IMHO manager should not handle errors and print errors only for docker runtime, i mean to say it should be something dependent on container runtime i.e. container driver, suppose i use rocket driver then this message doesn't make sense,
  2) Can we have different exceptions based on operation like ImagePullError or ContainerCreateError or something most appropriate, currently only DockerError is there.

In summary, in file zun/compute/manager.py, there are logic to handle docker-specific exception. However, manager should be generic so it should not handle runtime-specific error. This is because we are going to introduce another runtime in the future.

We need a fix to move all docker-specific code from manager.py to the docker driver.

hongbin (hongbin034)
Changed in zun:
status: New → Triaged
importance: Undecided → Medium
Changed in zun:
assignee: nobody → Pradeep Kumar Singh (pradeep-singh-u)
Revision history for this message
Pradeep Kumar Singh (pradeep-singh-u) wrote :

Will fix this in next week.

Changed in zun:
assignee: Pradeep Kumar Singh (pradeep-singh-u) → nobody
Kevin Zhao (kevin-zhao)
Changed in zun:
assignee: nobody → Kevin Zhao (kevin-zhao)
Kevin Zhao (kevin-zhao)
Changed in zun:
assignee: Kevin Zhao (kevin-zhao) → nobody
Eli Qiao (taget-9)
Changed in zun:
assignee: nobody → Eli Qiao (taget-9)
Revision history for this message
hongbin (hongbin034) wrote :

There is no activity for fixing this bug for a while. I am going to remove assignee so that other contributors can take it.

Changed in zun:
assignee: Eli Qiao (taget-9) → nobody
KS Kim (kiseok7)
Changed in zun:
assignee: nobody → Kiseok Kim (kiseok7)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.