Zun

Add a param 'mandatory' to Type classes to make sure that field is not empty.

Bug #1634780 reported by Madhuri Kumari on 2016-10-19

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Zun	Fix Released	Low	Pradeep Kumar Singh

Bug Description

With patch https://review.openstack.org/#/c/380298/ , we feel importance of having param 'mandatory' to type class to remove duplicate classes like ImageNameType, NameType etc.

Tags:

Madhuri Kumari (madhuri-rai07) on 2016-10-19

Changed in zun:
status:	New → Confirmed
importance:	Undecided → Low
tags:	added: tech-debt

Namrata (sitlani-namrata) on 2016-10-19

Changed in zun:
assignee:	nobody → Namrata (sitlani-namrata)

Revision history for this message

shubham (shubham-git) wrote on 2016-10-25:

Hi Namrata,

Looks like there are 2 duplicate bugs for the same issue. https://bugs.launchpad.net/zun/+bug/1634779 and this bug are same. Since you have started working on this bug so I am closing https://bugs.launchpad.net/zun/+bug/1634779

Pradeep Kumar Singh (pradeep-singh-u) on 2016-12-06

Changed in zun:
assignee:	Namrata (sitlani-namrata) → Pradeep Kumar Singh (pradeep-singh-u)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-06: Fix proposed to zun (master)

Fix proposed to branch: master
Review: https://review.openstack.org/407432

Changed in zun:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-12-13: Fix merged to zun (master)

Reviewed: https://review.openstack.org/407432
Committed: https://git.openstack.org/cgit/openstack/zun/commit/?id=c7fa8549af6c047944b3b2cff06a80cbade8dfd5
Submitter: Jenkins
Branch: master

commit c7fa8549af6c047944b3b2cff06a80cbade8dfd5
Author: Pradeep Kumar Singh <email address hidden>
Date: Tue Dec 6 09:53:59 2016 +0000

Add mandatory option for validating the json input

    This patch adds mandatory option, which checks if a given
    parameter is mandatory or not, if the mandatory parameter
    is not specified in JSON input to REST API, then it raises
    exception.

Closes-Bug: #1634780
Change-Id: I54987580d49f7d0fb1230177a28d32f49564da6c