Zorba

wrongError regressions in FOTS tests involving integers

Bug #1178322 reported by Markos Zaharioudakis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zorba
Fix Committed
High
Paul J. Lucas

Bug Description

It seems that the latest integers implementation introduces a number of "wrongError" regressions, i.e., tests that used to pass, but now return the wrong error code.

With BIG_INTEGER OFF, the following tests regress:

testset="prod-CastExpr.derived" testcase="cbcl-cast-ncname-002"
testset="prod-CastExpr.derived" testcase="cbcl-cast-date-004"
testset="prod-CastExpr.derived" testcase="cbcl-cast-dateTime-004"
testset="prod-CastExpr.derived" testcase="cbcl-cast-unsignedShort-002"
testset="prod-CastExpr.derived" testcase="cbcl-cast-gYear-001"
testset="prod-CastExpr.derived" testcase="cbcl-cast-gYearMonth-001"

With BIG_INTEGER ON, the following ADDITIONAL tests regress:

testset="prod-CastExpr.derived" testcase="cbcl-cast-nonNegativeInteger-001"
testset="prod-CastExpr.derived" testcase="cbcl-cast-unsignedByte-002"
testset="prod-CastExpr.derived" testcase="cbcl-cast-unsignedInt-002"
testset="prod-CastExpr.derived" testcase="cbcl-cast-unsignedLong-002"
testset="misc-CombinedErrorCodes" testcase="FOAR0002-5"
testset="fn-function-arity" testcase="fn-function-arity-017"
testset="fn-function-name" testcase="fn-function-name-018"

See original description
Tags: fots

Related branches

lp://staging/~zorba-coders/zorba/bug-1178322
Matthias Brantner: Approve
Paul J. Lucas: Approve
Diff: 809 lines (+165/-149)
7 files modified
src/runtime/core/path_iterators.cpp (+1/-1)
src/types/casting.cpp (+28/-18)
src/zorbatypes/decimal.cpp (+12/-3)
src/zorbatypes/float.cpp (+23/-18)
src/zorbatypes/float.h (+1/-2)
src/zorbatypes/integer.cpp (+36/-38)
src/zorbatypes/integer.h (+64/-69)
Paul J. Lucas (paul-lucas)
description: updated
Paul J. Lucas (paul-lucas)
Changed in zorba:
status: New → In Progress
Revision history for this message
Paul J. Lucas (paul-lucas) wrote :

Several of these failures have nothing to do with my integer changes. For example, for fn-function-arity-017, the code at translator.cpp:12459 currently says to throw XPST0017 that, according to the FOTS expected result, is wrong.

Revision history for this message
Paul J. Lucas (paul-lucas) wrote :

The integer-related failures have been fixed. However, as I mentioned previously, not all the failures are integer-related. I've opened several new bugs for the non-integer-related failures that remain.

Changed in zorba:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.