Boston skin widget_rows macro generates extra space
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Zope 3 | Status tracked in 3.4 | |||||
3.2 |
Fix Committed
|
Low
|
Unassigned | |||
3.3 |
Fix Committed
|
Low
|
Unassigned | |||
3.4 |
Fix Released
|
Low
|
Unassigned |
Bug Description
Summary: Firefox renders the Boston skin widget_rows macro with an extra 1em of space at the top of the table for each widget row in the table. For an edit view of a content object with lots of fields, it's very noticeable. It's a trivial fix, though.
Details:
In Boston skin zope/app/
<table id="widgets" border="0" cellspacing="0" cellpadding="0">
<div class="row" tal:repeat="widget view/widgets">
<tr>
...
</tr>
</div>
</table>
generating html like:
<table id="widgets" border="0" cellspacing="0" cellpadding="0">
<div class="row" >
<tr>
...
</tr>
</div>
<div class="row" >
<tr>
...
</tr>
</div>
<div class="row" >
<tr>
...
</tr>
</div>
....
</table>
However, Firefox "ejects" the <div> from the table and renders it like this:
<div class="row" > </div>
<div class="row" > </div>
<div class="row" > </div>
...
<table id="widgets" border="0" cellspacing="0" cellpadding="0">
<tr>
...
</tr>
<tr>
...
</tr>
<tr>
...
</tr>
....
</table>
Since each div.row has a style.padding-top= 1em, For each widget row, 1em of blank space is seen above the table. I wouldn't have noticed this except for a content object I have with lots of fields.
Internet explorer doesn't have a problem with the code. I don't know which browser is correct, but adding tal:omit-tag as follows will eliminate the problem.
line 6: <div class="row" tal:omit-tag="" tal:repeat="widget view/widgets">
Made the HTML valid. Revision 78758.