Zim

Don't freeze the dialog when searching

Bug #796215 reported by Robin Lee
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Zim
Fix Released
Undecided
Oliver Joos

Bug Description

By 0.52, when searching, the Search dialog turns frozen. It would be more friendly if a progress bar shows how much texts have been scanned and disappears when search finishes.

Revision history for this message
Oliver Joos (oliver-joos) wrote :

I hacked together an improved search dialog. It shows more clear when searching is going on, and when it ends without finding anything. For anyone who wants to test it: please download the attachment of this comment and replace the original zim/gui/serachdialog.py with it, then restart zim. Feedback is welcome!

@Robin: my 164 pages (about 700kB txt with 22MB attachments) are searched in less than a second. So I don't need a progress bar. What do you think of my attachment? Would it be ok for you, if "Searching..." is displayed instead of a growing progress bar?

Revision history for this message
Robin Lee (cheeselee) wrote :

Yes, your new dialog is clear. But it may be even better if moving "Searching.." to the center of the textarea.
I will change the title of this issue.

summary: - Show a progress bar when searching
+ Don't freeze the dialog when searching
Revision history for this message
Oliver Joos (oliver-joos) wrote :

Ok! The default position for text is in the center anyway. I tried to mimic Nautilus Search for files, but now agree with you.

Changed in zim:
assignee: nobody → Oliver Joos (oliver-joos)
status: New → In Progress
Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Implemented alternative fix in rev 467. Search is now responsive, shows results early and can be cancelled

Changed in zim:
status: In Progress → Fix Committed
Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Fixed in zim 0.55

Changed in zim:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.