Ubuntu Dock icons not clickable at the edge of the screen

Bug #1966167 reported by Guilherme
84
This bug affects 14 people
Affects Status Importance Assigned to Milestone
Dash to dock
New
Unknown
Yaru Theme
New
Unknown
gnome-shell-extension-ubuntu-dock (Ubuntu)
Fix Released
High
Marco Trevisan (Treviño)
Jammy
Fix Released
High
Marco Trevisan (Treviño)
yaru-theme (Ubuntu)
Fix Released
High
Marco Trevisan (Treviño)
Jammy
Fix Released
High
Marco Trevisan (Treviño)

Bug Description

[ Impact ]

If you go to the bottom left corner of the dock and click, the All Apps button doesn't get triggered or highlighted. Check attached video for details.

[ Test case ]

For verifying yaru-theme, in the Ubuntu session:
 1. Move the pointer to the edge of the screen where the AppIcons button is visible
    (bottom-left corner by default)
 2. The button should be highlighted and clicking it should open the applications grid

[ Regression potential ]

- The dock margins are wrong or icons are not clickable in their edges
- There's no not-reactive space between the activity button and the first icon

---

Ubuntu 21.10. Live mode. 1920x1080 screen.

Revision history for this message
Guilherme (raploz) wrote :
Paul White (paulw2u)
affects: ubuntu → gnome-shell-extension-ubuntu-dock (Ubuntu)
tags: added: impish
removed: 21.10
Revision history for this message
Daniel van Vugt (vanvugt) wrote (last edit ):

That's frustrating. We've fixed this twice already (bug 1873321, bug 1942702) and it's regressed again. I can see the same bug in 22.04 (scale 200%).

tags: added: jammy regression
summary: - All apps button in dock doesn't respect Fitts Law
+ Show Applications button is not clickable in the corner of the screen
Revision history for this message
Launchpad Janitor (janitor) wrote : Re: Show Applications button is not clickable in the corner of the screen

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: New → Confirmed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Would it be controlled by Yaru now?

tags: added: rls-jj-incoming
Changed in yaru:
status: Unknown → New
summary: - Show Applications button is not clickable in the corner of the screen
+ Ubuntu Dock icons not clickable at the edge of the screen
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in yaru-theme (Ubuntu):
status: New → Confirmed
Changed in dash-to-dock:
status: Unknown → New
tags: added: desktop-lts-wishlist
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: Confirmed → In Progress
Changed in yaru-theme (Ubuntu):
status: Confirmed → Triaged
status: Triaged → In Progress
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in yaru-theme (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in yaru-theme (Ubuntu Jammy):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Jammy):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 74ubuntu1

---------------
gnome-shell-extension-ubuntu-dock (74ubuntu1) kinetic; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * New EGO upstream bugfix release 74
  * debian/control: Bump dependency on gnome-shell << 44 (LP: #1990423)
  * docking: Respect St.Settings for animation duration
  * stylesheet: Increase apps tooltips margins
  * stylesheet: Set margin for default app-running dots
  * stylesheet: Remove upstream defined dash-item-container's children margins
    (LP: #1966167)
  * stylesheet: Do not add edge padding to edge elements
  * stylesheet: Fix definition for dash-separator in shrink mode
  * appIcons: Add missing implementation of _setPoupTimeout to wrapped toggle
  * appIcons: Also redirect arguments, to called methods if any
  * appIcons: Implement setForcedHighlight function in DockShowAppsIcons
  * appIcons: Modernize and cleanup DockShowAppsIcon code
  * docking: Fix arguments for overridden _getAppDisplayBoxForState
  * Settings: Move the Shrink option to the global theme settings
  * prefs: Do not request resizing of our root widget on startup
  * prefs: Never use a scrolled window in newer GNOME Shell
  * appIcons: Monitor windows workspace changes when isolating workspaces
  * locations: Make FileManagerApp emit windows-changed on workspace switches
    (LP: #1971012)
  * stylesheet: Take in account side margin and opposite padding in separators
  * stylesheet: Explicitly use border radius and spacing from upstream
  * stylesheet: Simplify dash separator definition based on upstream one
  * stylesheet: Use unique function to handle padding/margin on internal
    children
  * stylesheet: avoid computing the shrunk dash padding multiple times
  * stylesheet: Use generic style generator for shrink mode too
  * stylesheet: Move mixins to the top of the file for easier re-usage
  * stylesheet: Use dock-container-style to define the extended cases too
  * docking: Move style classes names to Theming
  * dash, stylesheet: Support shrink and position-based style for labels
  * stylesheet: Move dock specific variables to dock namespace
  * stylesheet: Sync global variable definitions with upstream

  [ David Astillero Pérez ]
  * Update Spanish translation

  [ Jose Riha ]
  * Update Slovak translation

  [ rene-coty ]
  * Updated French Translation

 -- Marco Trevisan (Treviño) <email address hidden> Sat, 24 Sep 2022 10:02:45 +0200

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yaru-theme - 22.10.3

---------------
yaru-theme (22.10.3) kinetic; urgency=medium

  * dock: Sync theme with upstream d2d fixes.
    This includes fixes coming from:
     - https://github.com/micheleg/dash-to-dock/pull/1826
     - https://github.com/micheleg/dash-to-dock/pull/1827
    And more importantly:
     - Increase apps tooltips margins
     - Set margin for default app-running dots
     - Remove upstream defined dash-item-container's children margin
       (LP: #1966167)
     - Do not add edge padding to edge elements
     - Fix definition for dash-separator in shrink mode
     - Take in account side margin and opposite padding in separators
     - Explicitly use border radius and spacing from upstream
     - Simplify dash separator definition based on upstream one
     - Use unique function to handle padding/margin on internal children
     - avoid computing the shrunk dash padding multiple times
     - Use generic style generator for shrink mode too
     - Move mixins to the top of the file for easier re-usage
     - Use dock-container-style to define the extended cases too
     - Support shrink and position-based style for labels
     - Move dock specific variables to dock namespace
     - Sync global variable definitions with upstream

 -- Marco Trevisan (Treviño) <email address hidden> Sat, 24 Sep 2022 11:11:01 +0200

Changed in yaru-theme (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Jammy):
status: New → Confirmed
Changed in yaru-theme (Ubuntu Jammy):
status: New → Confirmed
Revision history for this message
Efthimios Chaskaris (echaskaris) wrote :

Bug appears in 22.04.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
importance: Undecided → High
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Jammy):
importance: Undecided → High
Changed in yaru-theme (Ubuntu):
importance: Undecided → High
Changed in yaru-theme (Ubuntu Jammy):
importance: Undecided → High
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Jammy):
status: Confirmed → Fix Committed
Changed in yaru-theme (Ubuntu Jammy):
status: Confirmed → Fix Committed
description: updated
Revision history for this message
Steve Langasek (vorlon) wrote : Proposed package upload rejected

An upload of yaru-theme to jammy-proposed has been rejected from the upload queue for the following reason: "upload includes 450 lines of diff against cinnamon CSS which don't appear linked to any bugs in changelog".

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Guilherme, or anyone else affected,

Accepted yaru-theme into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/yaru-theme/22.04.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-jammy
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

marco-ThinkPad-X1-Carbon-7th ~ 5s 18:22:50
❯ apt-cache policy gnome-shell-extension-ubuntu-dock
gnome-shell-extension-ubuntu-dock:
  Installed: 72~ubuntu5.22.04.2.1
  Candidate: 72~ubuntu5.22.04.2.1
  Version table:
 *** 72~ubuntu5.22.04.2.1 500
        500 http://archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy-updates/main i386 Packages
        100 /var/lib/dpkg/status
     72~ubuntu5 500
        500 http://archive.ubuntu.com/ubuntu jammy/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy/main i386 Packages

marco-ThinkPad-X1-Carbon-7th ~ 18:23:27
❯ apt-cache policy yaru-theme-gnome-shell
yaru-theme-gnome-shell:
  Installed: 22.04.5
  Candidate: 22.04.5
  Version table:
 *** 22.04.5 400
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main amd64 Packages
        400 http://archive.ubuntu.com/ubuntu jammy-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     22.04.4 500
        500 http://archive.ubuntu.com/ubuntu jammy/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy/main i386 Packages

The fix is confirmed

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I see this bug also affects gnome-shell-extension-ubuntu-dock, but in jammy-proposed I only see yaru-theme. Is the gnome-shell-extension-ubuntu-dock package needed for this to go forward?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It's committed to the git branch 'ubuntu-dock-jammy' but not in proposed yet.

The desktop team policy of saying 'Fix Committed' before anything is even in proposed was started by Seb. I wouldn't mind if we revisited that though because it does confuse other teams and even ourselves.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

No, yaru changes are enough for Ubuntu. Different story is for the gnome session if one uses the dock provided by the package.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yaru-theme - 22.04.5

---------------
yaru-theme (22.04.5) jammy; urgency=medium

  [ Paul Kepinski ]
  * Add osd monitor labels theming (LP: #1979037)
  * Fix slider states (LP: #2019475)
  * Gtk3: fix marks scale visibilty on hover (LP: #2019477)
  * Gtk3: fix invisible check and radio in selected row (LP: #2019476)
  * Fix uncentered cursors (LP: #2019479)
  * Sync Gtk3 with upstream (only reference code, see debian/README.source)

  [ Marco Trevisan (Treviño) ]
  * dock: Fix margins making the dock show-apps clickable (LP: #1966167)
  * debian: Update references to ubuntu/jammy branch
  * nautilus: Ensure disk-space-display items are themed (LP: #2008791)
  * debian/README.sources: Explain better the role of the upstream folders

 -- Marco Trevisan (Treviño) <email address hidden> Fri, 09 Jun 2023 21:38:14 +0200

Changed in yaru-theme (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for yaru-theme has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.