Yarock

compilation of yarock-1.1.5 fails on Fedora23 with phonon enabled

Bug #1530432 reported by martinkg
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Yarock
New
Undecided
Unassigned

Bug Description

when compiling yarock-1.1.5 on Fedora23 with the following flags, yarock want to takes the old qt4 phonon header files.

%cmake \
  -DENABLE_PHONON:BOOL=ON \
  -DENABLE_VLC:BOOL=OFF \

yarock takes the old phonon qt4 header file from phonon/mediasource.h
but for yarock with qt5, the header file is located under /usr/include/phonon4qt5/phonon/mediasource.h

# rpm -ql phonon-qt5-devel |grep mediasource.h
/usr/include/phonon4qt5/phonon/experimental/mediasource.h
/usr/include/phonon4qt5/phonon/mediasource.h

# rpm -ql phonon-devel |grep mediasource.h
/usr/include/phonon/experimental/mediasource.h
/usr/include/phonon/mediasource.h

...
- Found qt5x11extra include-dir path: /usr/include/qt5/;/usr/include/qt5/QtX11Extras;/usr/include/qt5/QtGui;/usr/include/qt5/QtCore;/usr/lib64/qt5/.//mkspecs/linux-g++;/usr/include
-- Found qt5 private header include-dir path: /usr/include/qt5/QtGui/5.5.1;/usr/include/qt5/QtGui/5.5.1/QtGui;/usr/include/qt5/QtCore/5.5.1;/usr/include/qt5/QtCore/5.5.1/QtCore
-- Audio Engine Vlc................................................. OFF [use cmake .. -DENABLE_VLC=ON/OFF]
-- Audio Engine Mpv................................................. OFF [use cmake .. -DENABLE_MPV=ON/OFF]
-- Audio Engine Phonon.............................................. ON [use cmake .. -DENABLE_PHONON=ON/OFF]
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.28")
-- checking for module 'phonon4qt5'
-- found phonon4qt5, version 4.8.3
-- Found Phonon4Qt5: /usr/lib64/libphonon4qt5.so
-- Found LibPhonon4qt5 include-dir path: /usr/include
-- Found LibPhonon4qt5 library path:/usr/lib64/libphonon4qt5.so
...

compilation error message:

[100%] Building CXX object src/core/player/phonon/CMakeFiles/enginephonon.dir/enginephonon_automoc.cpp.o
cd /home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/x86_64-redhat-linux-gnu/src/core/player/phonon && /usr/bin/c++ -DENABLE_PHONON -DENABLE_SHORTCUT -DQT_CONCURRENT_LIB -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_PLUGIN -DQT_SHARED -DQT_THREAD -DQT_WIDGETS_LIB -DQT_XML_LIB -Denginephonon_EXPORTS -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -fPIC -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/./mkspecs/linux-g++ -I/usr/include/qt5/QtWidgets -I/usr/include/qt5/QtGui -I/usr/include/qt5/QtNetwork -I/usr/include/qt5/QtXml -I/usr/include/qt5/QtConcurrent -I/usr/include/qt5/QtDBus -I/usr/include/qt5/QtSql -I/usr/include/taglib -I/home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/src/shortcuts -I/home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/src/core/player/phonon/../../../../src/core/player -I/home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/src/core/player/phonon/../../../../src/core/player/phonon -I/home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/src/core/player/phonon/../../../../src/core/mediaitem -I/home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/src/core/player/phonon/../../../../src -I/phonon4qt5 -Wall -Wextra -Wall -fPIC -o CMakeFiles/enginephonon.dir/enginephonon_automoc.cpp.o -c /home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/x86_64-redhat-linux-gnu/src/core/player/phonon/enginephonon_automoc.cpp
In file included from /home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/src/core/player/phonon/engine_phonon.cpp:20:0:
/home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/src/core/player/phonon/engine_phonon.h:30:32: fatal error: phonon/mediasource.h: No such file or directory
 #include <phonon/mediasource.h>
                                ^
compilation terminated.
In file included from /home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/x86_64-redhat-linux-gnu/src/core/player/phonon/moc_engine_phonon.cpp:9:0,
                 from /home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/x86_64-redhat-linux-gnu/src/core/player/phonon/enginephonon_automoc.cpp:2:
/home/martin/rpmbuild/BUILD/Yarock_1.1.5_source/x86_64-redhat-linux-gnu/src/core/player/phonon/../../../../../src/core/player/phonon/engine_phonon.h:30:32: fatal error: phonon/mediasource.h: No such file or directory
 #include <phonon/mediasource.h>
                                ^
compilation terminated.

Revision history for this message
SebastienAmar (sebastien-amardeilh) wrote :

Hi Martin,

Can you try a "make clean all" after changing cmake options. I never have this issue, so I assume it's only a cmake build files update issue.

Regards

Revision history for this message
martinkg (martin-gansser-c) wrote :

Hi Sebastien,

the problem only happens if the cmake flag -DENABLE_PHONON:BOOL=ON is set.
I only build the rpm package in the rpm build environment, so a "make clean all" is obsolet.

here are the complete build messages in the rpm build environment:
https://martinkg.fedorapeople.org/Packages/test/rpm_build_messages.txt

hope this helps.
Martin

Revision history for this message
martinkg (martin-gansser-c) wrote :

this is the rpm spec file to built the fedora rpm package:
https://martinkg.fedorapeople.org/Packages/test/yarock-1.1.5-qt5.spec

Revision history for this message
martinkg (martin-gansser-c) wrote :

Hi Sebastien,

on Fedora we need the following changes for qt5 enabled with phonon.
Please change this, thanks to Parag Nemade from Fedora.

# Fix the incorrect PHONON include directory for QT5
sed -i 's/PHONON_INCLUDE_DIR/PHONON4QT5_INCLUDE_DIR/g' src/core/player/phonon/CMakeLists.txt

Many thanks for this really great player !

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.