batch_meetings() function is not converting all values

Bug #1570446 reported by John L. Villalovos
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
yaml2ical
Fix Released
Undecided
John L. Villalovos

Bug Description

The batch_meetings() function is not converting all values.

For example if we call it with a 5 item list and tell it to split with a batch_size of 4, it will return a 5 item list but the last item will be None.

Changed in yaml2ical:
assignee: nobody → John L. Villalovos (happycamp)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to yaml2ical (master)

Reviewed: https://review.openstack.org/305528
Committed: https://git.openstack.org/cgit/openstack-infra/yaml2ical/commit/?id=cd1f4760dfd39268ae90fd4fd2a9bc654f34b95d
Submitter: Jenkins
Branch: master

commit cd1f4760dfd39268ae90fd4fd2a9bc654f34b95d
Author: John L. Villalovos <email address hidden>
Date: Wed Apr 13 16:53:36 2016 -0700

    Fix off by 1 error in batch_messages & add unit tests

    Fix an off by one error in the batch_messages function. And add some
    unit tests for the batch_messages function.

    Also handle if batch_size is less than or equal to zero. In that case
    just return the input messages.

    Change-Id: Id7be110379c212104fba70588b647dfd3a13e765
    Closes-Bug: #1570446

Changed in yaml2ical:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.