XPathSelect

autopilot/__init__.py (+4/-3)
autopilot/globals.py (+9/-2)
autopilot/ibus.py (+1/-1)
autopilot/input/_X11.py (+7/-2)
autopilot/input/_osk.py (+5/-0)
autopilot/input/_uinput.py (+5/-0)
autopilot/introspection/__init__.py (+14/-3)
autopilot/introspection/backends.py (+2/-2)
autopilot/introspection/constants.py (+1/-1)
autopilot/introspection/dbus.py (+95/-115)
autopilot/introspection/types.py (+619/-0)
autopilot/introspection/utilities.py (+6/-0)
autopilot/keybindings.py (+6/-2)
autopilot/matchers/__init__.py (+1/-1)
autopilot/process/_bamf.py (+10/-8)
autopilot/testcase.py (+5/-4)
autopilot/tests/functional/test_ap_apps.py (+31/-22)
autopilot/tests/functional/test_autopilot_functional.py (+6/-4)
autopilot/tests/functional/test_dbus_query.py (+15/-2)
autopilot/tests/functional/test_input_stack.py (+7/-2)
autopilot/tests/functional/test_introspection_features.py (+2/-1)
autopilot/tests/functional/test_open_window.py (+1/-1)
autopilot/tests/functional/test_process_emulator.py (+1/-1)
autopilot/tests/unit/test_command_line_args.py (+9/-2)
autopilot/tests/unit/test_custom_exceptions.py (+1/-1)
autopilot/tests/unit/test_introspection_features.py (+36/-5)
autopilot/tests/unit/test_matchers.py (+41/-30)
autopilot/tests/unit/test_pick_backend.py (+1/-1)
autopilot/tests/unit/test_platform.py (+7/-1)
autopilot/tests/unit/test_types.py (+579/-0)
autopilot/tests/unit/test_version_utility_fns.py (+2/-2)
autopilot/utilities.py (+6/-7)
autopilot/vis/bus_enumerator.py (+5/-5)
autopilot/vis/main_window.py (+20/-12)
autopilot/vis/objectproperties.py (+8/-2)
autopilot/vis/resources.py (+1/-1)
bin/autopilot (+21/-20)
debian/changelog (+7/-0)
debian/control (+90/-12)
debian/python-autopilot-tests.install (+3/-0)
debian/python-autopilot-tests.pyinstall (+0/-3)
debian/python-autopilot-vis.install (+1/-0)
debian/python-autopilot-vis.pyinstall (+0/-1)
debian/python-autopilot.install (+6/-0)
debian/python-autopilot.pyinstall (+0/-6)
debian/python3-autopilot-tests.install (+3/-0)
debian/python3-autopilot-trace.install (+1/-0)
debian/python3-autopilot-vis.install (+1/-0)
debian/python3-autopilot.docs (+2/-0)
debian/python3-autopilot.install (+9/-0)
debian/python3-autopilot.postinst (+24/-0)
debian/rules (+30/-2)
docs/_templates/indexcontent.html (+6/-0)
docs/api/introspection.rst (+3/-0)
docs/appendix/appendix.rst (+9/-0)
docs/appendix/protocol.rst (+366/-0)
docs/conf.py (+3/-1)
docs/contents.rst (+1/-0)
docs/porting/porting.rst (+18/-0)
docs/tutorial/advanced_autopilot.rst (+1/-1)
setup.py (+1/-1)

I Ahmad (iahmad) on 2013-05-14

description:

updated

Revision history for this message

Martin Pitt (pitti) wrote on 2013-06-25:

This is rather vague, but I assume you are using the self.app.get_state_by_path() method to retrieve the raw D-BUS state array for an XPath? Further, this works in general (I'm currently writing test cases for this), but I can confirm that queries don't work which involve spaces in the property values. In XPath it is supposed to work with

"/Root//GtkWindow/GtkMenu/GtkImageMenuItem[name='_Save As']"

but it doesn't.

Changed in autopilot-gtk:
status:	New → Triaged
summary:	- Autopilot-gtk 1.3 doesn't return filtered results. + XPath queries with spaces in values don't work

Revision history for this message

Martin Pitt (pitti) wrote on 2013-06-25: Re: XPath queries with spaces in values don't work

Retitling bug accordingly. Please confirm that this is what you are seeing.

Revision history for this message

Martin Pitt (pitti) wrote on 2013-06-25:

Reproduced in test case: http://bazaar.launchpad.net/~pitti/autopilot-gtk/add-tests/revision/60

This also adds some other tests which confirm that XPath queries are working in general.

Martin Pitt (pitti) on 2013-06-26

summary:

- XPath queries with spaces in values don't work
+ XPath queries with quotes or spaces in values don't work

Revision history for this message

Martin Pitt (pitti) wrote on 2013-06-26:

xpathselect test case Edit (1.0 KiB, text/plain)

This is a bug in xpathselect. There is no way to quote a space, like with   or   or by quoting the attribute value.

Also, quotes themselves don't work in xpathselect. I attach a patch which adds two test cases, one for a quoted value, and one for a quoted value with a space.

Please note that current xpathselect violates the xpath specification: an expression like "/Root//*[visible=True]" selects a <visible> child with a string contents "True". Nodes with an attribute with that value are selected with "/Root//*[@visible=True]" , but xpathselect currently doesn't seem to handle the @. (See http://www.w3.org/TR/xpath/#path-abbrev). Changing that would need an accompanying fix in autopilot, and I guess it's not that urgent. But regardless of that, quotes should work, so that one can select arbitrary attribute or node values.

Changed in autopilot-gtk:
assignee:	Allan LeSage (allanlesage) → nobody
status:	Triaged → Invalid
tags:	added: has-testcase

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2013-06-26:

Hi,

This is a known issue in xpathselect. We have some tentative plans to fix it. However, we can work around this in autopilot in the mean time.

Martin: note that xpathsleect is not intended to implement the w3c xpath spec. Rather, it is "inspired by" xpathselect.

In the future, I plan to make the query language typed, so we can have proper quoted strings. Until then... lets work around this in autopilot.

Changed in xpathselect:
status:	New → Confirmed
importance:	Undecided → Low
Changed in autopilot:
status:	New → Confirmed
importance:	Undecided → High

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-16:

Fix committed into lp:xpathselect at revision 38, scheduled for release in xpathselect, milestone 1.3

Changed in xpathselect:
status:	Confirmed → Fix Committed

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-09-16:

Fix committed into lp:autopilot at revision 325, scheduled for release in autopilot, milestone 1.4

Changed in autopilot:
status:	Confirmed → Fix Committed

Thomi Richards (thomir-deactivatedaccount) on 2013-09-25

Changed in autopilot:
milestone:	none → 1.4

Thomi Richards (thomir-deactivatedaccount) on 2013-11-07

Changed in autopilot:
status:	Fix Committed → Fix Released
Changed in xpathselect:
status:	Fix Committed → Fix Released
no longer affects:	autopilot-gtk

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

xpathselect test case Edit

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.