Xibo

Copy Layout error in editing the content type and Embedded OR Ticker FEED / RSS - Windows Server Only

Bug #1321512 reported by Laercio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
Undecided
Dan Garner
Xibo 1.7.0-alpha2 "Tuttle"

Bug Description

Copy Layout error in editing the content type and Embedded Ticker

When performing a copy layout, marking replicate content or not identified the same problem.

The layout is copied successfully, but the content type or Embedded Ticker lose the reference edition. Always displays the first item in the list in the edit screen.

Related branches

lp://staging/~dangarner/xibo/server-170-alpha2
Xibo Maintainters: Pending requested
Diff: 30604 lines (+23044/-3722)
174 files modified
example_oauth/index.php (+14/-11)
server/config/client.config.php (+1/-1)
server/config/config.class.php (+6/-4)
server/install/database/80.sql (+1/-6)
server/install/database/81.sql (+23/-0)
server/install/master/data.sql (+6/-7)
server/install/master/structure.sql (+5/-3)
server/lib/app/cache.class.php (+82/-0)
server/lib/app/debug.class.php (+180/-169)
server/lib/app/kit.class.php (+456/-445)
server/lib/app/modulemanager.class.php (+2/-5)
server/lib/app/permissionmanager.class.php (+1/-3)
server/lib/app/responsemanager.class.php (+3/-1)
server/lib/app/session.class.php (+11/-4)
server/lib/app/thememanager.class.php (+56/-0)
server/lib/app/translationengine.class.php (+69/-68)
server/lib/data/campaign.data.class.php (+3/-1)
server/lib/data/campaignsecurity.data.class.php (+9/-0)
server/lib/data/datasetdata.data.class.php (+4/-0)
server/lib/data/datasetgroupsecurity.data.class.php (+18/-40)
server/lib/data/display.data.class.php (+133/-2)
server/lib/data/displayprofile.data.class.php (+55/-0)
server/lib/data/layout.data.class.php (+10/-18)
server/lib/data/maintenance.data.class.php (+156/-15)
server/lib/data/media.data.class.php (+101/-5)
server/lib/data/region.data.class.php (+5/-10)
server/lib/data/schedule.data.class.php (+578/-516)
server/lib/data/stat.data.class.php (+121/-63)
server/lib/data/usergroup.data.class.php (+52/-0)
server/lib/include.php (+8/-2)
server/lib/modules/module.class.php (+53/-47)
server/lib/pages/admin.class.php (+37/-71)
server/lib/pages/campaign.class.php (+36/-29)
server/lib/pages/content.class.php (+6/-5)
server/lib/pages/display.class.php (+53/-73)
server/lib/pages/displaygroup.class.php (+15/-25)
server/lib/pages/index.class.php (+10/-0)
server/lib/pages/install.class.php (+7/-1)
server/lib/pages/layout.class.php (+102/-59)
server/lib/pages/log.class.php (+4/-2)
server/lib/pages/module.class.php (+5/-4)
server/lib/pages/oauth.class.php (+1/-0)
server/lib/pages/preview.class.php (+3/-1)
server/lib/pages/schedule.class.php (+13/-12)
server/lib/pages/stats.class.php (+153/-9)
server/lib/pages/template.class.php (+14/-25)
server/lib/pages/timeline.class.php (+239/-57)
server/lib/pages/user.class.php (+4/-3)
server/lib/service/rest.class.php (+15/-2)
server/lib/service/service.wsdl (+3/-2)
server/lib/service/xmdssoap.class.php (+120/-90)
server/lib/xmds.inc.php (+8/-5)
server/locale/dbtranslate.php (+4/-0)
server/maintenance.php (+119/-172)
server/manual/content/admin/release_notes_1.7.0-alpha2.php (+84/-0)
server/manual/content/routes.php (+1/-0)
server/manual/content/toc_developer_releasenotes.php (+1/-0)
server/manual/template.php (+1/-1)
server/modules/3rdparty/forecast.php (+38/-0)
server/modules/clock.module.php (+33/-48)
server/modules/datasetview.module.php (+41/-14)
server/modules/embedded.module.php (+247/-193)
server/modules/font.module.php (+187/-0)
server/modules/forecastio.module.php (+508/-0)
server/modules/module_user_general.php (+39/-14)
server/modules/preview/Html4TransitionalTemplate.html (+26/-0)
server/modules/preview/HtmlTemplate.html (+9/-3)
server/modules/preview/HtmlTemplateForGetResource.html (+0/-155)
server/modules/preview/HtmlTemplateSimple.html (+1/-1)
server/modules/preview/fonts.css (+11/-0)
server/modules/preview/html-preview.js (+1/-1)
server/modules/preview/vendor/jquery-cycle-2.1.6.min.js (+16/-0)
server/modules/preview/vendor/jquery.marquee.min.js (+5/-0)
server/modules/preview/xibo-dataset-render.js (+51/-0)
server/modules/preview/xibo-layout-scaler.js (+62/-0)
server/modules/preview/xibo-text-render.js (+43/-211)
server/modules/preview/xibo-webpage-render.js (+81/-69)
server/modules/text.module.php (+150/-102)
server/modules/theme/HtmlTemplateForClock.html (+1/-1)
server/modules/theme/HtmlTemplateForFlipClock.html (+1/-1)
server/modules/theme/forecastio/weather_icons/weather-icons.min.css (+23/-0)
server/modules/theme/forecastio/weather_icons/weathericons-regular-webfont.svg (+153/-0)
server/modules/ticker.module.php (+93/-39)
server/modules/webpage.module.php (+303/-189)
server/services.php (+4/-2)
server/theme/default/css/html-preview.css (+2/-2)
server/theme/default/html/campaign_form_layout_assign.php (+2/-19)
server/theme/default/html/campaign_form_layout_assign_list.php (+0/-39)
server/theme/default/html/footer.php (+27/-7)
server/theme/default/html/form_grid_pager.php (+0/-41)
server/theme/default/html/grid_pager.php (+14/-15)
server/theme/default/html/grid_render.php (+1/-0)
server/theme/default/html/header.php (+7/-6)
server/theme/default/html/layout_designer.php (+2/-5)
server/theme/default/html/schedule_page.php (+1/-1)
server/theme/default/html/settings_page.php (+103/-86)
server/theme/default/html/stats_page_availability.php (+47/-0)
server/theme/default/html/stats_page_grid.php (+0/-6)
server/theme/default/html/status_dashboard.php (+2/-2)
server/theme/default/html/table_render.php (+110/-48)
server/theme/default/js/xibo-calendar.js (+8/-7)
server/theme/default/js/xibo-cms.js (+347/-63)
server/theme/default/js/xibo-forms.js (+24/-10)
server/theme/default/libraries/bootstrap-ekko-lightbox/ekko-lightbox.min.css (+6/-0)
server/theme/default/libraries/bootstrap-ekko-lightbox/ekko-lightbox.min.js (+7/-0)
server/theme/default/libraries/calendar/js/language/de-DE.js (+0/-73)
server/theme/default/libraries/calendar/js/language/de.js (+73/-0)
server/theme/default/libraries/ckeditor/config.js (+4/-1)
server/theme/default/libraries/ckeditor/contents.css (+2/-2)
server/theme/default/libraries/jquery-message-queuing/jquery.ba-jqmq.min.js (+9/-0)
server/theme/default/libraries/jquery-tablesorter/addons/pager/jquery.tablesorter.pager.css (+42/-0)
server/theme/default/libraries/jquery-tablesorter/addons/pager/jquery.tablesorter.pager.js (+958/-0)
server/theme/default/libraries/jquery-tablesorter/addons/pager/jquery.tablesorter.pager.min.js (+2/-0)
server/theme/default/libraries/jquery-tablesorter/css/bootstrap.less (+316/-0)
server/theme/default/libraries/jquery-tablesorter/css/filter.formatter.css (+183/-0)
server/theme/default/libraries/jquery-tablesorter/css/metro.less (+351/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.black-ice.css (+186/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.blue.css (+221/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.bootstrap.css (+152/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.bootstrap_2.css (+150/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.dark.css (+187/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.default.css (+189/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.dropbox.css (+212/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.green.css (+203/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.grey.css (+245/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.ice.css (+201/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.jui.css (+156/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.less (+323/-0)
server/theme/default/libraries/jquery-tablesorter/css/theme.metro-dark.css (+192/-0)
server/theme/default/libraries/jquery-tablesorter/js/extras/jquery.quicksearch.js (+191/-0)
server/theme/default/libraries/jquery-tablesorter/js/extras/semver-mod.js (+1026/-0)
server/theme/default/libraries/jquery-tablesorter/js/extras/semver.js (+1011/-0)
server/theme/default/libraries/jquery-tablesorter/js/jquery.metadata.js (+116/-0)
server/theme/default/libraries/jquery-tablesorter/js/jquery.tablesorter.js (+1901/-0)
server/theme/default/libraries/jquery-tablesorter/js/jquery.tablesorter.min.js (+5/-0)
server/theme/default/libraries/jquery-tablesorter/js/jquery.tablesorter.widgets-filter-formatter-select2.js (+138/-0)
server/theme/default/libraries/jquery-tablesorter/js/jquery.tablesorter.widgets-filter-formatter.js (+1145/-0)
server/theme/default/libraries/jquery-tablesorter/js/jquery.tablesorter.widgets-filter-formatter.min.js (+6/-0)
server/theme/default/libraries/jquery-tablesorter/js/jquery.tablesorter.widgets.js (+1912/-0)
server/theme/default/libraries/jquery-tablesorter/js/jquery.tablesorter.widgets.min.js (+17/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-date-extract.js (+81/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-date-iso8601.js (+34/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-date-month.js (+33/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-date-two-digit-year.js (+74/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-date-weekday.js (+33/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-date.js (+36/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-duration.js (+40/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-feet-inch-fraction.js (+63/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-file-type.js (+73/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-ignore-articles.js (+61/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-image.js (+20/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-input-select.js (+161/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-ipv6.js (+76/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-metric.js (+77/-0)
server/theme/default/libraries/jquery-tablesorter/js/parsers/parser-roman.js (+117/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-alignChar.js (+145/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-build-table.js (+453/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-columnSelector.js (+317/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-cssStickyHeaders.js (+70/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-editable.js (+200/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-grouping.js (+249/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-headerTitles.js (+91/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-math.js (+413/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-output.js (+316/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-pager.js (+975/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-print.js (+123/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-reflow.js (+179/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-repeatheaders.js (+50/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-scroller.js (+218/-0)
server/theme/default/libraries/jquery-tablesorter/js/widgets/widget-staticRow.js (+124/-0)
server/theme/default/libraries/jquery/jquery.metadata.js (+0/-116)
server/theme/default/libraries/jquery/jquery.tablesorter.pack.js (+0/-6)
server/theme/default/libraries/jquery/jquery.tablesorter.pager.css (+0/-28)
server/theme/default/libraries/jquery/jquery.tablesorter.pager.js (+0/-2)
Laercio (laercionit)
summary: - Copy Layout error in editing the content type and Embedded Ticker
+ Copy Layout error in editing the content type and Embedded OR Ticker
+ FEED / RSS
Revision history for this message
Laercio (laercionit) wrote : Re: Copy Layout error in editing the content type and Embedded OR Ticker FEED / RSS

Anyone else identifies the same problem?

The only way to solve is identified exclude (feeds / embeded) and raise them to click novamente.Assim edit content references are maintained.

Revision history for this message
Laercio (laercionit) wrote :

Anyone else identifies the same problem?

The only way to solve it is to delete identified (feeds / embeded) and insert again. Thus references content editing are maintained.

The timeline behind all of the items, but for some reason keeps references only the first content item.

If you have 5 or embeded Feeds, copying the layout appeared in the right amount, but when editing, where content is presented first.

Revision history for this message
Dan Garner (dangarner) wrote :

Sorry, but I don't understand the problem. Can you list out the steps to re-create?

Changed in xibo:
status: New → Incomplete
Revision history for this message
Laercio (laercionit) wrote :

Process for generating bug

Create a layout
Create a region
In the region place the following items embeded type, one for each item below.

item 1
<iframe AllowTransparency = "true" frameborder = "0" src = "http://tempo.suatv.com.br/WidgetCidade.aspx?guid=7d960eca-543a-4bdb-bed4-668d4b939fad" style = "height: 300px; width: 170px; border: 0; "> </ iframe>

item 2
<iframe AllowTransparency = "true" frameborder = "0" src = "http://tempo.suatv.com.br/WidgetCidade.aspx?guid=303cab01-2a62-403f-b7c7-943dcbe77421" style = "height: 300px; width: 170px; border: 0; "> </ iframe>

item 3
<iframe AllowTransparency = "true" frameborder = "0" src = "http://tempo.suatv.com.br/WidgetCidade.aspx?guid=81e6b60c-30b6-4577-976d-518e1e868289" style = "height: 300px; width: 170px; border: 0; "> </ iframe>

item 4
<iframe AllowTransparency = "true" frameborder = "0" src = "http://tempo.suatv.com.br/WidgetCidade.aspx?guid=380f4e48-ea02-4c71-a30f-0cac437061b4" style = "height: 300px; width: 170px; border: 0; "> </ iframe>

Layout Test to see if the content embeded this working.

Use the Copy Layout

Access to the region that has embeded codes.

You will see that the items were NOT copied correctly, but when scheduling the layout are displayed correctly ....

For my tests this bug happens in embeded type and ticker

Revision history for this message
Laercio (laercionit) wrote :
Revision history for this message
Laercio (laercionit) wrote :

After I informed the process above, you have the opportunity to validate that the bug exists?

Revision history for this message
Laercio (laercionit) wrote :

Hello,

Dan, you had the opportunity to confirm the error mentioned in the script tests I did?

Revision history for this message
Dan Garner (dangarner) wrote :

Sorry, but I am not sure what the problem is - what happens to the ticker / embedded content on copy?

Changed in xibo:
milestone: none → 1.7.0-alpha2
assignee: nobody → Dan Garner (dangarner)
Revision history for this message
Laercio (laercionit) wrote :

Dan, see the image of the timeline layout CLONE LayoutCopyError.jpg.
See the timeline of the original layout LayoutOriginal.jpg

The copy function works, the layout works perfectly copied.
The error when trying to edit this timeline clone layout.

See the pictures and understand, I did put the process so you can recreate the error.

Revision history for this message
Dan Garner (dangarner) wrote :

Hi Laercio, sorry my message wasn't clear... I understand what you say is happening, but I can't seem to recreate it following your instructions.

It is also hard to see how this could happen logically either - clearly it is happening, but I can't see how. Are you running a standard CMS?

Revision history for this message
Laercio (laercionit) wrote : Re: [Bug 1321512] Re: Copy Layout error in editing the content type and Embedded OR Ticker FEED / RSS

Dan, I will create layouts and demonstrate the problem in CMS Demo we
created last week.

Okay?

I'll try to recreate ...

Revision history for this message
Laercio (laercionit) wrote : Re: Copy Layout error in editing the content type and Embedded OR Ticker FEED / RSS

Dan, did the tests on the DEMO environment and could not recreate the problem.
In my environment the problem happens ....

Some guidance? My server is windows.

Changed in xibo:
status: Incomplete → Invalid
Revision history for this message
Laercio (laercionit) wrote :

Dan, did the tests and identified the problem, but not sure how to troubleshoot.

When I use the function key CopyLayout Media ID is the same on all items and embedded ticker.
Could you tell me which file should I check and the problem line of code?

 </script>]]></embedScript></raw>
                     </media><media id="8bc4e7f5a1f997ae549acd3607e857be" type="embedded" duration="30" lkid="" userId="3" schemaVersion="1">
                             <options><transparency>1</transparency><name>3</name></options>
                             <raw><embedHtml><![CDATA[<iframe AllowTransparency = "true" frameborder = "0" src = "http://tempo.suatv.com.br/WidgetCidade.aspx?guid=81e6b60c-30b6-4577-976d-518e1e868289" style = "height: 300px; width: 170px; border: 0; "> </ iframe>]]></embedHtml><embedScript><![CDATA[<script type="text/javascript">
 function EmbedInit()
 {
  // Init will be called when this page is loaded in the client.

  return;
 }
 </script>]]></embedScript></raw>
                     </media><media id="8bc4e7f5a1f997ae549acd3607e857be" type="embedded" duration="30" lkid="" userId="3" schemaVersion="1">
                             <options><transparency>1</transparency><name>4</name></options>
                             <raw><embedHtml><![CDATA[<iframe AllowTransparency = "true" frameborder = "0" src = "http://tempo.suatv.com.br/WidgetCidade.aspx?guid=380f4e48-ea02-4c71-a30f-0cac437061b4" style = "height: 300px; width: 170px; border: 0; "> </ iframe>]]></embedHtml><embedScript><![CDATA[<script type="text/javascript">
 function EmbedInit()
 {

Revision history for this message
Laercio (laercionit) wrote :

I looked at the file lib \ data \ layout.data.class.php 518 line, this identically to the original, nothing is different, do not know for what reason this is happening.

NOTE: This problem happens to me since version 1.4.2. Is it something related to windows environment?

Revision history for this message
Laercio (laercionit) wrote :

LogId
Data
Page
Function
Mensagem
150 2014-10-13 23:13:36 LayoutRegionGroupSecurity Copy IN
149 2014-10-13 23:13:36 CampaignGroupSecurity Copy OUT
148 2014-10-13 23:13:36 CampaignGroupSecurity Copy IN
144 2014-10-13 23:13:36 layout Copy Finished looping through media nodes
143 2014-10-13 23:13:36 LayoutMediaGroupSecurity Copy IN
142 2014-10-13 23:13:36 layout Copy Checking to see if embedded is RegionSpecific
141 2014-10-13 23:13:36 layout Copy Media embedded node found with id 0
140 2014-10-13 23:13:36 LayoutMediaGroupSecurity Copy IN
139 2014-10-13 23:13:36 layout Copy Checking to see if embedded is RegionSpecific
138 2014-10-13 23:13:36 layout Copy Media embedded node found with id 0
137 2014-10-13 23:13:36 LayoutMediaGroupSecurity Copy IN
136 2014-10-13 23:13:36 layout Copy Checking to see if embedded is RegionSpecific
135 2014-10-13 23:13:36 layout Copy Media embedded node found with id 0
134 2014-10-13 23:13:36 LayoutMediaGroupSecurity Copy IN
133 2014-10-13 23:13:36 layout Copy Checking to see if embedded is RegionSpecific
132 2014-10-13 23:13:36 layout Copy Media embedded node found with id 73
131 2014-10-13 23:13:36 layout Copy About to loop through media nodes

Revision history for this message
Laercio (laercionit) wrote :

Dan, this error appears in this function, but unfortunately I can not reproduce the test environment we create.
All Media ID embedded given the same ID, the same problem occurs in the ticker. As I understand this error when generating a new ID and save the XML column.

// If this is a non region specific type, then move on
                if ($this->IsRegionSpecific($type))
                {
                    // Generate a new media id
                    $newMediaId = md5(uniqid());

                    $mediaNode->setAttribute('id', $newMediaId);

Revision history for this message
Laercio (laercionit) wrote :

Dan, I just try to install a new environment.
I did the same tests using version 1.6.4

The same problem happened, is something related functionality in my server environment.

If you have possibility to check:

user: xibo
Password: xibo
url: //admin.suatv.com.br/164/

Do see the items in the timeline layout (default layout) and make a copy.

Revision history for this message
Laercio (laercionit) wrote :

http://admin.suatv.com.br/164/phpinfo.php

Revision history for this message
Laercio (laercionit) wrote :

Dan, I think it may be related to the topic: https://www.drupal.org/node/2045699

My opinion is that it is a bug that exists only in windows environment. Therefore when PHP calls the md5 (uniqid ()); all appear with the same ID Media.

Revision history for this message
Laercio (laercionit) wrote :

Dan, the problem was solved by adjusting the function below.

I can not validate if there was a difference for the UNIX environment, but for windows solved.

   // Generate a new media id
                     $ newMediaId = md5 (uniqid (time (), TRUE));

Revision history for this message
Laercio (laercionit) wrote :

both worked

$ newMediaId = md5 (uniqid (time (), TRUE));

or

$ newMediaId = md5 (uniqid ($ _ SERVER ['REQUEST_TIME'], true));

Changed in xibo:
status: Invalid → Confirmed
summary: Copy Layout error in editing the content type and Embedded OR Ticker
- FEED / RSS
+ FEED / RSS - Windows Server Only
Revision history for this message
Dan Garner (dangarner) wrote :

Ah, i see... that is very interesting! So the problem appears to be that windows doesn't generate a uniqueid each time when using the uniqueid function.

In that case, either of your solutions would appear to work fine - there is a built in Kit method that could be used instead

Kit::uniqueId();

I will target and fix this for 1.7.0-alpha2.

Thanks for the debug while I was asleep! :)

Dan Garner (dangarner)
Changed in xibo:
status: Confirmed → Triaged
status: Triaged → Fix Committed
Revision history for this message
Laercio (laercionit) wrote :

Dan, I have to change the code modification that I made?

$ NewMediaId = md5 (uniqid ($ _ SERVER ['REQUEST_TIME'], true));

for your solution

Kit :: uniqueId ();

Revision history for this message
Dan Garner (dangarner) wrote :

You can keep your solution - they are essentially the same.

Revision history for this message
Laercio (laercionit) wrote :

Ok Dan, I tried make the change to your code.
Did not work for me. Can not even finish the copy of the layout.

Revision history for this message
Dan Garner (dangarner) wrote :

you can revert to your solution - lets not make additional work for ourselves :-)

The code is tested and working here.

Thanks,
Dan

Revision history for this message
Laercio (laercionit) wrote :

Dan, sorry, I know that this issue apparently resolved with the modification that I made. But with the modification that you made ​​not to operate the copy of the layout.

The process does not even make a copy with the previous error. Simply does not finish copying.

Revision history for this message
Dan Garner (dangarner) wrote :

This is the change: http://bazaar.launchpad.net/~dangarner/xibo/server-170-alpha2/view/head:/server/lib/data/layout.data.class.php#L602 correct?

Revision history for this message
Laercio (laercionit) wrote :

Dan realized that the changes identified in the related files:

http://bazaar.launchpad.net/~dangarner/xibo/server-170-alpha2/revision/374
Making these changes only the copy process did not work.

I saw the link (http://bazaar.launchpad.net/~dangarner/xibo/server-170-alpha2/view/head:/server/lib/data/layout.data.class.php#L602 ) Contains more changes than just the ones mentioned:

$ newMediaId = md5 (uniqid ()) = >>>> Kit :: uniqueId ();

Revision history for this message
Dan Garner (dangarner) wrote :

Perhaps you can leave your own change in place for your 1.6 installations and then take the entire 1.7 when it is ready.

If you have doubts that my change works could test in the entire 1.7 alpha2 branch.

Revision history for this message
Laercio (laercionit) wrote :

Ok Dan, I will keep my mod to version 1.7

But it was understood only with the change of the work function. Looking at the code I saw that there were more changes than just the line you mentioned.

What you need to test or help, just ask ....

Dan Garner (dangarner)
Changed in xibo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.