Node coordinates inside a group are inconsistent between the PropertyEditor and the Rulers
Bug #1281645 reported by
Stan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Workcraft |
Fix Committed
|
Low
|
Stan | ||
Bug Description
When entering a group, the coordinate system becomes relative to the group, which introduce confusion: the X and Y properties of the nodes displayed in the PropertyEditor are different from those observed on the Ruler. Similar inconsistency is visible when moving a group - its coordinates are relative to the nodes inside.
Here is two possible solutions:
Option 1: Change the ruler when entering a group (this would not solve the inconsistency of the group coordinates though).
Option 2: Recalculate the X and Y properties to global coordinates before displaying in the PropertyEditor, and back from global coordinates to local ones when editing them.
Related branches
lp://staging/~danilovesky/workcraft/trunk-bug-1343256
- Danil Sokolov: Approve
-
Diff: 1240 lines (+165/-447)24 files modifiedCircuitPlugin/src/org/workcraft/plugins/circuit/Circuit.java (+3/-3)
DfsPlugin/src/org/workcraft/plugins/dfs/Dfs.java (+1/-1)
DfsPlugin/src/org/workcraft/plugins/dfs/NamePropertyDescriptor.java (+0/-53)
PetriNetPlugin/src/org/workcraft/plugins/petri/NamePropertyDescriptor.java (+0/-53)
PetriNetPlugin/src/org/workcraft/plugins/petri/PetriNet.java (+1/-1)
SONPlugin/src/org/workcraft/plugins/son/NamePropertyDescriptor.java (+0/-56)
SONPlugin/src/org/workcraft/plugins/son/SON.java (+1/-0)
STGPlugin/src/org/workcraft/plugins/stg/STG.java (+1/-1)
STGPlugin/src/org/workcraft/plugins/stg/STGNameManager.java (+29/-52)
STGPlugin/src/org/workcraft/plugins/stg/propertydescriptors/NamePropertyDescriptor.java (+0/-54)
WorkcraftCore/src/org/workcraft/dom/AbstractModel.java (+6/-5)
WorkcraftCore/src/org/workcraft/dom/math/AbstractMathModel.java (+11/-25)
WorkcraftCore/src/org/workcraft/dom/math/MathNode.java (+5/-4)
WorkcraftCore/src/org/workcraft/dom/visual/AbstractVisualModel.java (+5/-31)
WorkcraftCore/src/org/workcraft/dom/visual/VisualTransformableNode.java (+30/-3)
WorkcraftCore/src/org/workcraft/gui/MainMenu.java (+6/-1)
WorkcraftCore/src/org/workcraft/gui/MainWindow.java (+24/-21)
WorkcraftCore/src/org/workcraft/gui/propertyeditor/GenericCellEditor.java (+11/-6)
WorkcraftCore/src/org/workcraft/gui/propertyeditor/NamePropertyDescriptor.java (+18/-14)
WorkcraftCore/src/org/workcraft/gui/propertyeditor/PropertyEditorTable.java (+5/-5)
WorkcraftCore/src/org/workcraft/observation/ObservableState.java (+1/-0)
WorkcraftCore/src/org/workcraft/workspace/WorkspaceEntry.java (+5/-0)
XmasPlugin/src/org/workcraft/plugins/xmas/NamePropertyDescriptor.java (+0/-56)
XmasPlugin/src/org/workcraft/plugins/xmas/Xmas.java (+2/-2)
| Changed in workcraft: | |
| milestone: | none → 3.0 |
| assignee: | nobody → Stan (sgaflv) |
| importance: | Undecided → Low |
| status: | New → Confirmed |
| summary: |
- coordinate system needs to show current group + Coordinate system needs to show current group |
| tags: | added: group ui |
| Changed in workcraft: | |
| status: | Confirmed → Opinion |
| importance: | Low → Wishlist |
| milestone: | 3.0 → none |
| Changed in workcraft: | |
| status: | Opinion → Confirmed |
| importance: | Wishlist → Low |
| summary: |
- Coordinate system needs to show current group + Node coordinates inside the groput is not consistent between the + PropertyEditor and the Rullers |
| description: | updated |
| summary: |
Node coordinates inside the groput is not consistent between the - PropertyEditor and the Rullers + PropertyEditor and the Rulers |
| Changed in workcraft: | |
| milestone: | none → 3.0 |
| summary: |
- Node coordinates inside the groput is not consistent between the + Node coordinates inside a group is inconsistent between the PropertyEditor and the Rulers |
| summary: |
- Node coordinates inside a group is inconsistent between the + Node coordinates inside a group are inconsistent between the PropertyEditor and the Rulers |
Revision history for this message
| Danil Sokolov (danilovesky) wrote | #1 |
| Changed in workcraft: | |
| status: | Confirmed → Fix Committed |
To post a comment you must log in.
Option 2 was implemented - setter and getter for X and Y properties recalculate node coordinates to the root components.