Editor: Map saving can contain critical characters
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Won't Fix
|
Critical
|
Unassigned |
Bug Description
We have a check for safe filenames when saving a map. This check can be circumvented by:
1. Open editor
2. Open map options and give a non suspicious name (there is another bug here: The OK button is initially grayed out. If you delete ' Name' and write ' Name' again, the OK button is not grayed out)
3. Click OK
4. Open Save map menu
5. Click on Map Options
6. Add some bad characters to the map name, e.g.: \/,`?
7. Click OK
Result: The Filename in the Save Map screen has now the bad characters and the OK button is not grayed out -> Saving possible
If you enter the editbox of the filename (in Save Map screen) and delete the last bad character, the OK button get disabled.
When entering an exclamation mark (!) in step 6, the behavior is as expected: The OK button is disabled. I guess this is due my file system, which allows all characters except the exclamation mark.
tags: | added: filesystem ui |
Changed in widelands: | |
milestone: | none → build21-rc1 |
something like this would help:
https:/ /bazaar. launchpad. net/~widelands- dev/widelands/ trunk/view/ head:/src/ network/ internet_ gaming. cc#L1036