MP Game Setup - UI errors
Bug #1407396 reported by
Tino
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
A list of problems, seescreenshot:
(1) Player Role Button is not aligned with table (only in fullscreen)
(2) Type column should be a bit wider, buttons centered with padding
(3) Could be less space (use for 5)
(4) Column could be smaller
(5) More space here (take from 3)
All but number 1 apply to both windowed and fullscreen mode.
Related branches
lp://staging/~widelands-dev/widelands/multiplayer_dropdowns
- SirVer: Approve (testing,compile,code-review)
- kaputtnik (community): Approve (testing)
-
Diff: 2785 lines (+1002/-778)29 files modifiedsrc/ai/computer_player.cc (+7/-6)
src/ai/computer_player.h (+17/-0)
src/ai/defaultai.h (+21/-18)
src/graphic/playercolor.h (+13/-0)
src/logic/CMakeLists.txt (+1/-0)
src/logic/game.cc (+3/-3)
src/logic/game_settings.cc (+38/-1)
src/logic/game_settings.h (+47/-3)
src/logic/single_player_game_settings_provider.cc (+9/-8)
src/logic/single_player_game_settings_provider.h (+1/-1)
src/network/CMakeLists.txt (+0/-1)
src/network/gameclient.cc (+11/-6)
src/network/gameclient.h (+2/-2)
src/network/gamehost.cc (+76/-113)
src/network/gamehost.h (+1/-1)
src/network/network_player_settings_backend.cc (+58/-123)
src/network/network_player_settings_backend.h (+9/-20)
src/network/network_protocol.h (+3/-2)
src/notifications/note_ids.h (+3/-1)
src/ui_basic/dropdown.cc (+67/-12)
src/ui_basic/dropdown.h (+31/-2)
src/ui_basic/listselect.cc (+2/-2)
src/ui_fsmenu/launch_game.cc (+5/-6)
src/ui_fsmenu/launch_mpg.cc (+30/-20)
src/ui_fsmenu/launch_mpg.h (+1/-0)
src/ui_fsmenu/launch_spg.cc (+5/-5)
src/wui/multiplayersetupgroup.cc (+528/-409)
src/wui/multiplayersetupgroup.h (+6/-6)
src/wui/playerdescrgroup.cc (+7/-7)
Revision history for this message
| Tino (tino79) wrote | #1 |
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #2 |
| tags: | added: lowhangingfruit menu ui |
| Changed in widelands: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #3 |
| Changed in widelands: | |
| milestone: | none → build20-rc1 |
| tags: | removed: menu |
| Changed in widelands: | |
| assignee: | nobody → GunChleoc (gunchleoc) |
| status: | Confirmed → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| assignee: | GunChleoc (gunchleoc) → nobody |
Revision history for this message
| GunChleoc (gunchleoc) wrote | #4 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I am not sure whether we should actually do something about 4, but I agree with your other points.
Keep in mind when changing this that texts (and especially the table headers) will be affected by translations and may require more space in some languages.