widelands

Widelands should never run as a daemon

Bug #1330068 reported by SirVer
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Low
Unassigned
widelands build19-rc1

Bug Description

--dedicated forks and puts Widelands in the background. That is the wrong approach - Widelands should always stay in the foreground. If background is desired, something like upstart should be used to launch it as a system process.

To fix this bug, forking must be removed from wlapplicatino.cc.

Related branches

lp://staging/~widelands-dev/widelands/dedicated_out_of_main
Tino: Approve
GunChleoc: Approve
Diff: 3599 lines (+457/-1848)
25 files modified
src/CMakeLists.txt (+0/-3)
src/io/CMakeLists.txt (+0/-13)
src/io/dedicated_log.cc (+0/-342)
src/io/dedicated_log.h (+0/-90)
src/logic/editor_game_base.cc (+1/-5)
src/logic/game.cc (+56/-108)
src/logic/game.h (+13/-7)
src/logic/game_settings.h (+0/-11)
src/main.cc (+0/-57)
src/map_io/map_building_packet.cc (+1/-2)
src/network/CMakeLists.txt (+0/-1)
src/network/internet_gaming.cc (+21/-22)
src/network/netclient.cc (+47/-163)
src/network/netclient.h (+0/-2)
src/network/nethost.cc (+102/-593)
src/network/nethost.h (+1/-8)
src/network/network_protocol.h (+7/-35)
src/sound/sound_handler.h (+0/-1)
src/ui_fsmenu/launch_mpg.cc (+0/-10)
src/ui_fsmenu/loadgame.cc (+164/-179)
src/ui_fsmenu/mapselect.cc (+39/-113)
src/wlapplication.cc (+2/-77)
src/wlapplication.h (+1/-1)
src/wlapplication_messages.cc (+0/-1)
src/wui/chat_msg_layout.cc (+2/-4)
SirVer (sirver)
tags: added: lowhangingfruit
SirVer (sirver)
tags: added: cleanups
removed: cleanup
Revision history for this message
SirVer (sirver) wrote :

Setting to incomplete for bug sweeping.

Changed in widelands:
status: Confirmed → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for widelands because there has been no activity for 60 days.]

Changed in widelands:
status: Incomplete → Expired
SirVer (sirver)
Changed in widelands:
status: Expired → Confirmed
Revision history for this message
Jens Beyer (qcumber-some) wrote :

Bug 1416864 shows some issues with --dedicated. One of them is, that it does not fork.

What's the real status of this bug?

Revision history for this message
SirVer (sirver) wrote :

Forking is a bad, bad idea. Not even servers do it these days anymore. The correct approach is to capture the console and have the process be launched and controlled by something like http://upstart.ubuntu.com/ - not to fork into the background.

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

I realize upstart was mentioned as an example, but please note that Ubuntu is currently moving away from it [1] in favor of systemd. Actually, despite some discussion around it, a lot of distributions have or are switching to systemd as their default init system[2]. If someone wants to create a service for running the dedicated server, that might be a place to start looking.

[1] http://www.markshuttleworth.com/archives/1316
[2] http://en.wikipedia.org/wiki/Systemd#Adoption_and_reception

SirVer (sirver)
Changed in widelands:
assignee: nobody → SirVer (sirver)
Revision history for this message
SirVer (sirver) wrote :

--dedicated is gone, so we never daemonize widelands ever.

Changed in widelands:
status: Confirmed → Fix Committed
assignee: SirVer (sirver) → nobody
milestone: none → build19-rc1
GunChleoc (gunchleoc)
tags: added: network
removed: dedicated
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.