With opengl enabled, screenshots display edges in terrain strangely
Bug #1202146 reported by
Hans Joachim Desserud
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Medium
|
cghislai | ||
Bug Description
Steps to reproduce:
1. Start a new game.
2. Take a screenshot (press f11)
3. Open the stored screenshot (typcally found in ~/.widelands/
4. Observe the image.
Expected result:
The screenshot is an exact replica of what was displayed in the Widelands window at the time it was taken.
Actual result:
Edges and differences in terrain seem to light up as unrendered parts (see attached example)
This only happens when opengl is enabled, screenshots stored with software rendering are fine. If others are not able to reproduce this with opengl enabled, it might be a driver issue I suppose, but please check.
Widelands bzr r6629 on Ubuntu 13.04.
Related branches
lp://staging/~widelands-dev/widelands/minimap
- SirVer: Approve
-
Diff: 654 lines (+216/-82)13 files modifiedsrc/game_io/game_preload_data_packet.cc (+27/-0)
src/game_io/game_preload_data_packet.h (+2/-0)
src/graphic/in_memory_image.cc (+2/-1)
src/graphic/render/gl_surface_screen.cc (+6/-0)
src/graphic/render/minimaprenderer.cc (+63/-54)
src/graphic/render/minimaprenderer.h (+20/-8)
src/logic/immovable.cc (+1/-1)
src/logic/worker_descr.cc (+0/-3)
src/ui_basic/icon.cc (+17/-4)
src/ui_basic/icon.h (+6/-1)
src/ui_fsmenu/loadgame.cc (+44/-2)
src/ui_fsmenu/loadgame.h (+10/-0)
src/wui/minimap.cc (+18/-8)
Revision history for this message
| Hans Joachim Desserud (hjd) wrote | #1 |
| Changed in widelands: | |
| status: | New → Confirmed |
| tags: | added: opengl |
Revision history for this message
| SirVer (sirver) wrote | #2 |
Revision history for this message
| cghislai (charlyghislain) wrote | #3 |
| Changed in widelands: | |
| assignee: | nobody → cghislai (charlyghislain) |
| status: | Confirmed → In Progress |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| SirVer (sirver) wrote | #4 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Same problem here - looks like some transparency issues. Might be that this is just a thing on how we write the pgm, so I'd start to investigate there. An easy fix might be to flatten the screen surface to RGB (from RGBA) before writing it out.