VM

delete-duplicate-messages for IMAP folders is unsafe

Bug #1004837 reported by Uday Reddy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
VM
In Progress
High
Uday Reddy

Bug Description

Here is a happening:

Did vm-get-new-mail on an IMAP folder. The network connection was non-functional and VM hung. When the network connection was fixed, it ended with

   vm-imap-check-connection: IMAP error: "not connected"

When I did another vm-get-new-mail, there was another error:

   vm-update-draft-count: Format specifier doesn't match argument type

But this seems to have aborted the vm-get-new-mail for some reason. The new messages retrieved in the process presumably have nil fields for UID's.

The next try of vm-get-new-mail fetched new copies of the messages, which were fine, but vm-delete-duplicate-messages in the arrive-messaged-hook marked them for deletion.

Then VM says:

  Found 2 messages with invalid UIDs. Expunge them? (y or n)

The invalid UID's were for the first copies, and vm-delete-duplicate-messages has marked the new good copies for deletion. So, answering `y' at this point deletes all the copies.

This is clearly unsafe.

Tags: 8.2 imap

Related branches

Uday Reddy (reddyuday)
Changed in vm:
status: Triaged → Fix Committed
Revision history for this message
Uday Reddy (reddyuday) wrote :

Fixed in rev. 1465.1.2.

Revision history for this message
Uday Reddy (reddyuday) wrote :

Valid messages are stil being deleted by vm-delete-duplicate-messages.

Changed in vm:
status: Fix Committed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.