Unwrapt

Unwrapt does not handle 'cdrom:' sources

Bug #682534 reported by mac9416
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unwrapt
New
Critical
Unassigned

Bug Description

unwrapt.utils.to_filename splits a source URL at the "//". That's fine if it's a normal URL, but 'cdrom:' lines contain no "//".

Here's the source that caused the error:
deb cdrom:[Ubuntu-Studio 10.10 _Maverick Meerkat_ - Release amd64 (20101008)]/ maverick main multiverse restricted universe

Revision history for this message
Chris Oliver (excid3) wrote :

Does it crash on these entries?

Since cdroms are clearly not a target (since they are offline) as long as it bypasses these lines without trouble I will be happy.

Revision history for this message
mac9416 (mac9416) wrote :

Yep, Unwrapt throws an IndexError because it tires to reference [1] of a list of one item: "cdrom:[Ubuntu-Studio 10.10 _Maverick Meerkat_ - Release amd64 (20101008)]/" split by "//".

Revision history for this message
Chris Oliver (excid3) wrote :

Alrighty. So, my thoughts were, if it's not a deb, then the line can be saved as a comment. This way we can reproduce the sources.list from Unwrapt itself even if we didn't have the original source. This will likely never be the case, but it's the same idea with how we allow saving of the status file. Thoughts?

Changed in unwrapt:
importance: Undecided → Critical
Revision history for this message
mac9416 (mac9416) wrote :

Yeah, save it as a comment. Perhaps with a comment on the end of the commented line explaining the change.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.