TerminalScreenlet broken

Bug #275125 reported by ASDFASDF
2
Affects Status Importance Assigned to Milestone
Universal Applets
Fix Committed
Undecided
Unassigned

Bug Description

TerminalScreenlet refuses to start (using Ubuntu 8.04 and bzr ver. of UA and UA-extras).
See the attached traceback.

Revision history for this message
ASDFASDF (user-487-deactivatedaccount) wrote :
Revision history for this message
Peter Ward (flowblok) wrote :

The attached patch fixes the issue by implementing a simple resize to the terminal whenever the scale is changed.
A better solution would be to link the layout of the terminal and vbox to the layout of the screenlet, but I couldn't see how to do that.

Revision history for this message
Peter Ward (flowblok) wrote :

Whoops - let's try again.

Revision history for this message
Natan Yellin (aantny) wrote :

IMO, the best way to handle resizes would be to notify the server that the applet would _like_ to resize and to allow the server to handle it as it wishes. (In UA, every applet is displayed in a server. The default server, melange, displays applets in toplevel windows.)

One example why it's better not to let the applet force a resize is applets that are displayed in sidebar or dock servers. Even if the applet wants to resize itself, it shouldn't be able to do so automatically and cause the entire dock/sidebar to resize.

Revision history for this message
Natan Yellin (aantny) wrote :

Sorry, I submitted my last comment too soon.

The Universal Applets DBUS API (which applets use to communicate with the server) still doesn't have a set_size or set_scale function. I'll try to add one tomorrow, but for now I'm applying your patch. Thanks.

Revision history for this message
Natan Yellin (aantny) wrote :

Committed in revision 116.

Changed in universal-applets:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.