Universal Applets

ClockScreenlet corrupted if size!=100%

Bug #275109 reported by ASDFASDF
2
Affects Status Importance Assigned to Milestone
Universal Applets
Fix Committed
High
Przemysław Firszt

Bug Description

If you try to change the size of the screenlet, hands will resize properly but the background will remain at 100%.
Also, closing and starting again doesn't fix it, but changing the theme does (???).
See the screenshot.

Revision history for this message
ASDFASDF (user-487-deactivatedaccount) wrote :
Revision history for this message
ASDFASDF (user-487-deactivatedaccount) wrote :
Natan Yellin (aantny)
Changed in universal-applets:
status: New → Confirmed
Revision history for this message
Peter Ward (flowblok) wrote :

This is a bug in ua-core/src/lib/screenlets/screenlets.py - none of the new on_signal events are actually called from setattr - I'm assuming that we're moving towards properties(?), but here's a patch to make most applets compatible again.

Revision history for this message
Natan Yellin (aantny) wrote :

We are moving away from setattr (we still don't use properties, though), but most of the on_* methods are called from the Screenlet.* methods. E.g. on_realize is called from Screenlet.realize.

Some of the on_* don't have a corresponding Screenlet.* method. (E.g. on_scale.) These should be called from setattr or using properties.

Natan Yellin (aantny)
Changed in universal-applets:
importance: Undecided → High
Revision history for this message
Przemysław Firszt (pefi) wrote :

Temporary solution commited. on_scale doesn't work (yet) so refresh_buffers is called in on_draw function, but it's only a workaround. Rev. 117 of extras.

Changed in universal-applets:
assignee: nobody → pefi
status: Confirmed → Fix Committed
Revision history for this message
Natan Yellin (aantny) wrote :

I fixed on_scale in Rev. 527 of core. The Clock works fine without the workaround in Rev. 119 of extras.

Let me know if any of the other on_* are broken.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.