Unity

signals connected in panel-service.c:on_entry_added never disconnected

  1. Series 5.0
  2. Bug #1203607
Bug #1203607 reported by Andrew Gaul
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Medium
Andrew Gaul
Unity 7.1.0
5.0
Fix Committed
Medium
Andrew Gaul
Unity 5.22.0 "SRU-5"
unity (Ubuntu)
Fix Released
Undecided
Unassigned
Nominated for Precise by Stephen M. Webb

Bug Description

I have observed unity-panel-service on Ubuntu 12.04 consuming hundreds of MB of memory (RSS) after about a month of uptime. I ran ubuntu-panel-service 5.20.0 with G_SLICE=always-malloc using Valgrind with --leak-check=full --track-origins=yes --show-reachable=yes --num-callers=100 for a few hours and attached a leak report. Here is a suspect trace:

==25653== 155,736 bytes in 2,163 blocks are possibly lost in loss record 12,412 of 12,412
==25653== at 0x4C2A964: calloc (vg_replace_malloc.c:593)
==25653== by 0x68D8AE0: g_malloc0 (gmem.c:189)
==25653== by 0x60E7B18: g_closure_new_simple (gclosure.c:206)
==25653== by 0x60E907F: g_cclosure_new (gclosure.c:917)
==25653== by 0x61000CD: g_signal_connect_data (gsignal.c:2443)
==25653== by 0x40AC57: on_entry_added (panel-service.c:841)
==25653== by 0x60E8CA1: g_closure_invoke (gclosure.c:777)
==25653== by 0x60F9D70: signal_emit_unlocked_R (gsignal.c:3547)
==25653== by 0x6102098: g_signal_emit_valist (gsignal.c:3296)
==25653== by 0x6102241: g_signal_emit (gsignal.c:3352)
==25653== by 0x4E39734: indicator_object_set_visible (in /usr/lib/libindicator3.so.7.0.0)
==25653== by 0x15F2A844: ???
==25653== by 0x60E8CA1: g_closure_invoke (gclosure.c:777)
==25653== by 0x60F9D70: signal_emit_unlocked_R (gsignal.c:3547)
==25653== by 0x6102098: g_signal_emit_valist (gsignal.c:3296)
==25653== by 0x6102241: g_signal_emit (gsignal.c:3352)
==25653== by 0xA0A5DF6: ??? (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==25653== by 0x60E8CA1: g_closure_invoke (gclosure.c:777)
==25653== by 0x60F9D70: signal_emit_unlocked_R (gsignal.c:3547)
==25653== by 0x6102098: g_signal_emit_valist (gsignal.c:3296)
==25653== by 0x6102241: g_signal_emit (gsignal.c:3352)
==25653== by 0xA0A62FD: ??? (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==25653== by 0xA2C9AC5: dbus_connection_dispatch (in /lib/x86_64-linux-gnu/libdbus-1.so.3.5.8)
==25653== by 0xA09F434: ??? (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==25653== by 0x68D2D52: g_main_context_dispatch (gmain.c:2539)
==25653== by 0x68D309F: g_main_context_iterate.isra.23 (gmain.c:3146)
==25653== by 0x68D3499: g_main_loop_run (gmain.c:3340)
==25653== by 0x51BC42C: gtk_main (in /usr/lib/x86_64-linux-gnu/libgtk-3.so.0.400.2)
==25653== by 0x407EC1: main (panel-main.c:431)

I will submit a review request which addresses this. Note that there are other suspicious activity in the log outside the scope of this issue.

Tags: memory-leak

Related branches

lp://staging/~gaul/unity/on_entry_added_leak
PS Jenkins bot (community): Approve (continuous-integration)
Christopher Townsend (community): Approve
Marco Trevisan (Treviño): Approve
Diff: 19 lines (+9/-0)
1 file modified
services/panel-service.c (+9/-0)
lp://staging/~gaul/unity/on_entry_added_leak_5.0
Marco Trevisan (Treviño): Approve
Christopher Townsend (community): Needs Fixing
Diff: 19 lines (+9/-0)
1 file modified
services/panel-service.c (+9/-0)
Superseded for merging into lp://staging/unity
Unity Team: Pending requested
Diff: 25805 lines (+18358/-228) (has conflicts)
162 files modified
AUTHORS (+17/-0)
CMakeLists.txt (+16/-0)
ChangeLog (+2441/-0)
HACKING (+4/-0)
UnityCore/DBusIndicators.cpp (+38/-2)
UnityCore/DBusIndicators.h (+4/-0)
UnityCore/GLibSignal.cpp (+16/-0)
UnityCore/GLibSignal.h (+4/-0)
UnityCore/Indicator.cpp (+28/-0)
dash/DashController.cpp (+80/-0)
dash/DashController.h (+3/-0)
dash/DashView.cpp (+111/-0)
dash/PlacesGroup.cpp (+6/-0)
dash/ResultRendererTile.cpp (+89/-11)
dash/ResultView.cpp (+10/-0)
dash/ResultViewGrid.cpp (+119/-0)
dash/ResultViewGrid.h (+29/-0)
dash/ScopeBar.cpp (+49/-0)
dash/ScopeBarIcon.cpp (+5/-0)
hud/HudButton.cpp (+50/-2)
hud/HudButton.h (+25/-0)
hud/HudController.cpp (+169/-3)
hud/HudController.h (+43/-5)
hud/HudIcon.cpp (+12/-0)
hud/HudView.cpp (+156/-11)
hud/HudView.h (+32/-1)
launcher/AbstractLauncherIcon.h (+31/-0)
launcher/ApplicationLauncherIcon.cpp (+507/-0)
launcher/ApplicationLauncherIcon.h (+28/-0)
launcher/BFBLauncherIcon.cpp (+9/-0)
launcher/DesktopLauncherIcon.cpp (+14/-0)
launcher/DeviceLauncherSection.cpp (+74/-0)
launcher/DeviceLauncherSection.h (+33/-0)
launcher/DndData.cpp (+20/-0)
launcher/EdgeBarrierController.cpp (+66/-12)
launcher/EdgeBarrierController.h (+4/-0)
launcher/HudLauncherIcon.cpp (+42/-0)
launcher/Launcher.cpp (+576/-1)
launcher/Launcher.h (+33/-1)
launcher/LauncherController.cpp (+331/-1)
launcher/LauncherController.h (+8/-0)
launcher/LauncherIcon.cpp (+64/-5)
launcher/LauncherIcon.h (+17/-0)
launcher/QuicklistMenuItem.cpp (+258/-0)
launcher/QuicklistMenuItem.h (+27/-0)
launcher/QuicklistMenuItemSeparator.cpp (+85/-0)
launcher/QuicklistMenuItemSeparator.h (+2/-0)
launcher/QuicklistView.cpp (+159/-1)
launcher/QuicklistView.h (+5/-0)
launcher/SimpleLauncherIcon.cpp (+12/-0)
launcher/SimpleLauncherIcon.h (+7/-0)
launcher/SoftwareCenterLauncherIcon.cpp (+47/-0)
launcher/SoftwareCenterLauncherIcon.h (+10/-0)
launcher/StandaloneLauncher.cpp (+20/-0)
launcher/SwitcherController.cpp (+139/-0)
launcher/SwitcherController.h (+23/-0)
launcher/SwitcherModel.cpp (+31/-0)
launcher/SwitcherModel.h (+27/-0)
launcher/SwitcherView.cpp (+42/-0)
launcher/SwitcherView.h (+11/-0)
launcher/TrashLauncherIcon.cpp (+30/-0)
launcher/VolumeLauncherIcon.cpp (+496/-0)
launcher/VolumeLauncherIcon.h (+55/-0)
manual-tests/Dash.txt (+60/-29)
manual-tests/Launcher.txt (+214/-0)
manual-tests/Panel.txt (+17/-0)
manual-tests/ShortcutsOverlay.txt (+1/-0)
manual-tests/SoftwareCenter.txt (+211/-104)
manual-tests/Switcher.txt (+91/-0)
manual-tests/WindowButtons.txt (+28/-0)
manual-tests/WindowManagement.txt (+23/-0)
panel/PanelController.cpp (+20/-1)
panel/PanelController.h (+5/-0)
panel/PanelMenuView.cpp (+31/-0)
panel/PanelView.cpp (+10/-0)
plugins/unityshell/src/HudAbstractView.cpp (+33/-0)
plugins/unityshell/src/HudAbstractView.h (+66/-0)
plugins/unityshell/src/LauncherControllerPrivate.h (+160/-0)
plugins/unityshell/src/ScreenEffectFramebufferObject.cpp.OTHER (+238/-0)
plugins/unityshell/src/UnityGestureBroker.cpp (+247/-0)
plugins/unityshell/src/UnityShowdesktopHandler.cpp (+9/-0)
plugins/unityshell/src/compizminimizedwindowhandler.h (+10/-0)
plugins/unityshell/src/unity-launcher-accessible.cpp (+10/-0)
plugins/unityshell/src/unity-util-accessible.cpp (+2/-2)
plugins/unityshell/src/unitya11y.cpp (+20/-0)
plugins/unityshell/src/unityshell.cpp (+753/-9)
plugins/unityshell/src/unityshell.h (+66/-1)
services/panel-service.c (+9/-0)
shortcuts/ShortcutController.cpp (+5/-0)
shortcuts/ShortcutView.cpp (+8/-0)
standalone-clients/CMakeLists.txt.OTHER (+574/-0)
tests/CMakeLists.txt (+191/-0)
tests/autopilot/autopilot/emulators/bamf.py.OTHER (+411/-0)
tests/autopilot/autopilot/keybindings.py.OTHER (+259/-0)
tests/autopilot/autopilot/matchers/__init__.py (+31/-0)
tests/autopilot/autopilot/utilities.py.OTHER (+78/-0)
tests/autopilot/unity/emulators/__init__.py (+289/-0)
tests/autopilot/unity/emulators/dash.py (+58/-1)
tests/autopilot/unity/emulators/hud.py (+5/-0)
tests/autopilot/unity/emulators/icons.py (+13/-0)
tests/autopilot/unity/emulators/launcher.py (+159/-2)
tests/autopilot/unity/emulators/quicklist.py (+46/-0)
tests/autopilot/unity/emulators/tooltip.py (+23/-0)
tests/autopilot/unity/emulators/window_manager.py (+25/-0)
tests/autopilot/unity/tests/__init__.py (+232/-0)
tests/autopilot/unity/tests/test_command_lens.py (+70/-0)
tests/autopilot/unity/tests/test_dash.py (+339/-6)
tests/autopilot/unity/tests/test_home_lens.py (+17/-0)
tests/autopilot/unity/tests/test_hud.py (+390/-0)
tests/autopilot/unity/tests/test_ibus.py (+189/-1)
tests/autopilot/unity/tests/test_launcher.py.OTHER (+999/-0)
tests/autopilot/unity/tests/test_panel.py (+507/-1)
tests/autopilot/unity/tests/test_quicklist.py (+319/-0)
tests/autopilot/unity/tests/test_shortcut_hint.py (+113/-0)
tests/autopilot/unity/tests/test_switcher.py (+58/-0)
tests/test-gestures/CMakeLists.txt (+6/-0)
tests/test-gestures/compiz_mock/core/screen.h (+30/-0)
tests/test-gestures/test_gesture_broker.cpp (+140/-0)
tests/test-minimize-window-handler/test-minimize-handler.cpp (+14/-0)
tests/test_dbus_indicators.cpp (+98/-0)
tests/test_glib_signals.cpp (+23/-0)
tests/test_hud_button.cpp (+76/-0)
tests/test_hud_controller.cpp (+87/-0)
tests/test_hud_private.cpp (+80/-0)
tests/test_hud_view.cpp (+74/-0)
tests/test_im_text_entry.cpp (+173/-0)
tests/test_keyboard_util.cpp (+118/-0)
tests/test_launcher_controller.cpp (+215/-0)
tests/test_main.cpp (+12/-0)
tests/test_resultviewgrid.cpp (+103/-0)
tests/test_service_lens.c.OTHER (+187/-0)
tests/test_service_main.cpp (+68/-0)
tests/test_service_panel.c (+253/-0)
tests/test_service_panel.h (+46/-0)
tests/test_switcher_controller.cpp (+43/-0)
tests/test_time_util.cpp (+38/-0)
tests/test_uscreen_mock.h (+87/-1)
tests/test_utils.h (+31/-0)
tests/unit/TestQuicklistMenuitems.cpp.OTHER (+258/-0)
tools/unity.cmake (+50/-1)
unity-shared/DebugDBusInterface.cpp (+24/-0)
unity-shared/IMTextEntry.cpp (+81/-0)
unity-shared/IMTextEntry.h (+13/-0)
unity-shared/IconRenderer.cpp (+183/-0)
unity-shared/IconTexture.cpp (+2/-0)
unity-shared/IconTexture.h (+4/-0)
unity-shared/OverlayRenderer.cpp (+51/-1)
unity-shared/PluginAdapter.cpp (+222/-0)
unity-shared/PluginAdapter.h (+36/-0)
unity-shared/SearchBar.cpp (+18/-4)
unity-shared/StaticCairoText.cpp (+37/-0)
unity-shared/TimeUtil.h (+6/-0)
unity-shared/UBusMessages.h (+10/-0)
unity-shared/UScreen.cpp (+82/-8)
unity-shared/UScreen.h (+19/-0)
unity-shared/UnityWindowView.cpp (+48/-0)
unity-shared/UnityWindowView.h (+9/-0)
unity-shared/WindowButtons.cpp (+103/-0)
unity-shared/XKeyboardUtil.cpp (+44/-0)
unity-shared/XKeyboardUtil.h (+34/-0)
unity-shared/XWindowManager.cpp (+249/-0)
unity-shared/XWindowManager.h (+132/-0)
Revision history for this message
Andrew Gaul (gaul) wrote :
Andrew Gaul (gaul)
summary: - signals added in panel-service.c:on_entry_added never disconnected
+ signals connected in panel-service.c:on_entry_added never disconnected
Marco Trevisan (Treviño) (3v1n0)
Changed in unity:
importance: Undecided → Medium
status: New → In Progress
milestone: none → 7.1.0
assignee: nobody → Andrew Gaul (gaul)
Revision history for this message
Christopher Townsend (townsend) wrote :

Hi Andrew,

Marco gave some instructions for getting this into the 5.0 branch for 12.04. Once you get that done and approved, we'll work on getting this in the 12.04 Unity SRU. We'll help you with that.

Thanks for your contributions!

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone 7.1.0

Changed in unity:
status: In Progress → Fix Committed
Marco Trevisan (Treviño) (3v1n0)
Changed in unity (Ubuntu):
status: New → In Progress
status: In Progress → Fix Committed
Revision history for this message
Stephen M. Webb (bregma) wrote :

Fix Released in Unity Unity 7.1.0.

Changed in unity:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 7.1.0+13.10.20130729-0ubuntu1

---------------
unity (7.1.0+13.10.20130729-0ubuntu1) saucy; urgency=low

  [ Stephen M. Webb ]
  * upstream release 7.1.0

  [ Andrew Gaul ]
  * PanelService: Disconnect signals connected in panel-
    service.c:on_entry_added. (LP: #1203607)

  [ Chris Townsend ]
  * Change to using ellipsis instead of three dots for the "Installing"
    tooltip. (LP: #1203092)

  [ Andrea Azzarone ]
  * Add show_desktop_key film in unityshell plugin. (LP: #1204664)

  [ Marco Trevisan (Treviño) ]
  * TestPanelService: verify that the entry's label and icon are
    disconnected on removal.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 3443
 -- Ubuntu daily release <email address hidden> Mon, 29 Jul 2013 04:04:13 +0000

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.