Dash - the options in the "filter results" section are the wrong size, aligned incorrectly, and the button outline width is incorrect
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
High
|
John Lea | ||
Unity |
Fix Released
|
Undecided
|
Mirco Müller | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The options in the "filter results" section are the wrong size, aligned incorrectly, and the button outline width is incorrect.
See file_lens_
The issues are:
- The "All" button is the wrong shape (botten w=48px h=30px incl. 1px line-width or 2px for selected state)
- The spacing below the row which contains the 'category title' (e.g. "Last modified", "Type", etc...) and the "All" button, and the first row of filters is far too large. (distance all-button to first row of genre-button 12px)
- There is not enough margin between the options on the right hand side of the filter options and the edge of the Dash (needs to be 15px)
- The outline used for the buttons is too bright (ping chaotic or rosie on IRC for the value). These lines should have some transparency and appear much fainter, see design above.
- the separator line between categories is 2px high when it should be 1px high (use a generared texture with a 1px line to avoid this)
- In the file lens there should not be a scroll bar to the right of the filters. This is appearing because the vertical spacing is wrong (spacing between genre-buttons needs to be 12px vert. and 10px horiz).
- The range selectors ('size' and 'decade') are both far too short (same height as the genre buttons, 30px incl. outline, some systems do have this working already... but why?)
- a separator is displayed below at the very end of the filters, this needs to be removed (there should never be a separator at the end)
- the highlight on active buttons is too opaque (ping chaotic or rosie on IRC for exact value)
Related branches
- Andrea Azzarone (community): Approve
-
Diff: 503 lines (+156/-170)4 files modifiedplugins/unityshell/resources/dash-widgets.json (+2/-2)
plugins/unityshell/src/DashStyle.cpp (+151/-164)
plugins/unityshell/src/DashStyle.h (+1/-2)
plugins/unityshell/src/FilterGenreWidget.cpp (+2/-2)
- Andrea Azzarone (community): Approve
- Andrea Cimitan (community): Approve (design)
-
Diff: 406 lines (+105/-50)10 files modifiedplugins/unityshell/resources/dash-widgets.json (+2/-2)
plugins/unityshell/src/DashSearchBar.cpp (+8/-4)
plugins/unityshell/src/FilterBar.cpp (+30/-2)
plugins/unityshell/src/FilterBasicButton.cpp (+10/-3)
plugins/unityshell/src/FilterExpanderLabel.cpp (+39/-14)
plugins/unityshell/src/FilterExpanderLabel.h (+5/-1)
plugins/unityshell/src/FilterGenreWidget.cpp (+2/-10)
plugins/unityshell/src/FilterMultiRangeWidget.cpp (+1/-9)
plugins/unityshell/src/FilterRatingsWidget.cpp (+1/-1)
plugins/unityshell/src/PlacesGroup.cpp (+7/-4)
tags: | added: onew udo |
Changed in unity: | |
assignee: | nobody → John Lea (johnlea) |
assignee: | John Lea (johnlea) → nobody |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → Critical |
status: | New → Fix Committed |
Changed in unity: | |
status: | New → Triaged |
milestone: | none → 4.24.0 |
Changed in unity (Ubuntu): | |
status: | New → Triaged |
milestone: | none → oneiric-updates |
Changed in unity: | |
assignee: | nobody → Robert Carr (robertcarr) |
description: | updated |
Changed in unity: | |
status: | Triaged → In Progress |
Changed in unity: | |
milestone: | 4.24.0 → 4.26.0 |
Changed in ayatana-design: | |
status: | Fix Committed → Triaged |
tags: | added: udp |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
milestone: | 4.26.0 → 5.0.0 |
description: | updated |
Changed in unity: | |
assignee: | Robert Carr (robertcarr) → Mirco Müller (macslow) |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in unity: | |
milestone: | 5.0.0 → 5.2.0 |
Changed in unity: | |
milestone: | 5.2.0 → 5.0.0 |
Changed in unity: | |
milestone: | 5.0.0 → 5.2.0 |
Changed in unity (Ubuntu): | |
milestone: | oneiric-updates → none |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in ayatana-design: | |
importance: | Critical → High |
tags: | added: furtherdesignreviewrequiredp |
https:/ /bugs.launchpad .net/unity/ +bug/897611/ +attachment/ 2612222/ +files/ Screenshot% 20at%202011- 11-29%2010% 3A06%3A22. png