Hints exposed through properties needed (e.g.; to discriminate downloads in the indicator)
Bug #1364964 reported by
Sergio Schvezov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Transfer Indicator |
Confirmed
|
Undecided
|
Charles Kerr | ||
| unity-scope-click |
New
|
Medium
|
Alejandro J. Cura | ||
| ubuntu-download-manager (Ubuntu) |
Fix Released
|
Medium
|
Manuel de la Peña | ||
Bug Description
CreateMMS[
There is a possibility of using the metadata, or use of a HintSystem prop which can be easily parsed.
ProblemType: Bug
DistroRelease: Ubuntu 14.10
Package: ubuntu-
Uname: Linux 3.4.0-5-mako armv7l
ApportVersion: 2.14.7-0ubuntu1
Architecture: armhf
Date: Wed Sep 3 10:53:56 2014
InstallationDate: Installed on 2014-09-03 (0 days ago)
InstallationMedia: Ubuntu Utopic Unicorn (development branch) - armhf (20140903-091005)
SourcePackage: ubuntu-
UpgradeStatus: No upgrade log present (probably fresh install)
Related branches
lp://staging/~mandel/ubuntu-download-manager/properties
- PS Jenkins bot: Approve (continuous-integration)
- Ricardo Mendoza (community): Approve
-
Diff: 816 lines (+410/-29)19 files modifiedCMakeLists.txt (+1/-1)
debian/changelog (+7/-0)
debian/libudm-common0.symbols (+12/-0)
docs/dbus/com.canonical.applications.download.xml (+10/-4)
src/common/public/ubuntu/transfers/metadata.cpp (+54/-3)
src/common/public/ubuntu/transfers/metadata.h (+15/-0)
src/downloads/priv/ubuntu/downloads/download.cpp (+19/-0)
src/downloads/priv/ubuntu/downloads/download.h (+9/-1)
src/downloads/priv/ubuntu/downloads/download_adaptor.cpp (+19/-1)
src/downloads/priv/ubuntu/downloads/download_adaptor.h (+16/-4)
src/downloads/priv/ubuntu/downloads/file_download.cpp (+11/-8)
src/downloads/priv/ubuntu/downloads/mms_file_download.cpp (+2/-0)
tests/downloads/client/test_client_manager.cpp (+1/-1)
tests/downloads/daemon/test_download.cpp (+29/-0)
tests/downloads/daemon/test_download.h (+2/-0)
tests/downloads/daemon/test_metadata.cpp (+159/-6)
tests/downloads/daemon/test_metadata.h (+18/-0)
tests/downloads/daemon/test_mms_download.cpp (+25/-0)
tests/downloads/daemon/test_mms_download.h (+1/-0)
Revision history for this message
| Sergio Schvezov (sergiusens) wrote | #1 |
| Changed in ubuntu-download-manager (Ubuntu): | |
| status: | New → Confirmed |
| assignee: | nobody → Charles Kerr (charlesk) |
| assignee: | Charles Kerr (charlesk) → nobody |
| Changed in indicator-transfer: | |
| status: | New → Confirmed |
| assignee: | nobody → Charles Kerr (charlesk) |
Revision history for this message
| Charles Kerr (charlesk) wrote | #2 |
| Changed in ubuntu-download-manager (Ubuntu): | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Manuel de la Peña (mandel) |
| importance: | Undecided → Medium |
| Changed in unity-scope-click: | |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| Changed in unity-scope-click: | |
| importance: | Undecided → Medium |
| tags: | added: rtm14 |
| tags: | added: ota-future |
| Changed in ubuntu-download-manager (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Adding affects indicator-transfer since it will be the first consumer of this metadata.
The main pieces of information that would help indicator-transfer are:
1. A flag to denote whether this download should be shown in the indicator at all; e.g. MMS messages should never be shown. Possible key name: ShowInIndicator
2. A human-readable title. Design's mockups use title examples of "Top 10 animation films", "Sunny day at the beach", Sunny day at the beach 2", but use your best judgement -- if that level of metainfo isn't available, even a basename of the file we're downloading would be better than nothing. Possible key name: Title
3. If the download is going to be consumed by a click app, the name of that app. indicator-transfer needs this for (a) extracting its icon for the menuitem and (b) to know what app to launch when the user clicks on a completed download in the indicator's menu. Possible key name: ClickPackage