Do not show files that are not reachable
Bug #599271 reported by
Seif Lotfy
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Fix Released
|
Medium
|
Mikkel Kamstrup Erlandsen | ||
unity-lens-files |
Fix Released
|
Undecided
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Files that are not reachable because they have been moved or deleted should not appear in the documents view.
However if nautilus is patched to tell us that something was copied or moved we could still display it by showing the right path.
However deleted items should not be there at all...
Related branches
lp://staging/~seif/unity-lens-files/check-path
- Unity Team: Pending requested
-
Diff: 123 lines (+53/-45)1 file modifiedsrc/daemon.vala (+53/-45)
Changed in unity: | |
milestone: | none → 2010-07-22 |
assignee: | nobody → Mikkel Kamstrup Erlandsen (kamstrup) |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity-place-files: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu): | |
status: | New → Fix Released |
To post a comment you must log in.
I certainly agree that we shouldn't display deleted items, but stat()ing each file in the result set is a bit scary to me. It is however, by far, the easiest solution right now.
The Real Fix (TM) is to fix bug #489194 and make Zeitgeist respect the StorageState parameter in the query.
Before I merge something like Seif's branch I'd like to consider if we can lighted the IO load a bit somehow... Any ideas? Perhaps some clever caching + monitoring parent dirs of result uris...