WebApps: unity-firefox-extension

Remove the automatic generation of the *_gen_* private functions jsc-types bindings

Bug #1111732 reported by Alexandre Abreu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
WebApps: unity-firefox-extension
New
Undecided
Unassigned
unity-firefox-extension (Ubuntu)
Fix Released
Undecided
Unassigned
Quantal
Fix Released
Medium
Unassigned

Bug Description

[Impact]

At the moment, the jsc-types bindings (needed so that the extension can directly access the C API functions exported by libunity-webapps) are being generated automatically every time one builds the extension by direct parsing of the gir files generated from libunity-webapps.

Part of those exported bindings are some internal functions part of libunity-webapps that are being wrongly exported as symbols along with public parts of the API. This has been fixed in libunity-webapps trunk, where those symbols are not being exported. But now the issue is that we have a chicken and egg problem:

- we cannot release a new libunity-webapps version since the already released unity-firefox-extension will look for those missing bindings and break if they are not found,

- we cannot guarantee that releasing both libunity-webapps and unity-firefox-extension the user will install both at the same time, and it is not recommended (to keep packages individually "revertible") to add dependencies between updates,

Therefore, this update to unity-firefox-extension does not actually change very much that would be user visible; but it is a necessary prerequisite to a larger libunity-webapps SRU that we will be submitting after this one is approved. If this does not get approved, then the libunity-webapps SRU that we need to do will not function at all.

The idea is to make sure that we can release a new libunity-webapps version (that does not export anymore the private symbols) that won't break the ufe extension. We statically generate the bindings, instead of dynamically then, to have control over what the extension tries to bind with.

The list of bindings is the same as before, just without the private symbols (not used by the extension anyway).

[Test Case]

Verify that the extension works as expected under Firefox:

- opening a integrated website e.g. bbc.co.uk/news or twitter.com
- accepting the integration,
- making sure that an integration happens: launcher icon is there along with some notifications and/or messaging menu integration (in the case of twitter),

[Regression Potential]

None really since we only remove some function bindings that are anyway not exposed/used by the extension. The worst case would be that no integration happens anymore at all.

See original description

Related branches

lp://staging/~abreu-alexandre/unity-firefox-extension/remove-unity-webapps-generation
PS Jenkins bot (community): Approve (continuous-integration)
Maxim Ermilov (community): Approve
Diff: 578 lines (+561/-2)
2 files modified
unity-firefox-extension/build.sh (+6/-2)
unity-firefox-extension/content/unity-webapps.js (+555/-0)
lp://staging/~robru/unity-firefox-extension/quantal-sru-candidate
Ken VanDine: Approve
Diff: 10583 lines (+7671/-710)
162 files modified
.pc/.quilt_patches (+0/-1)
.pc/.quilt_series (+0/-1)
.pc/.version (+0/-1)
debian/changelog (+47/-0)
po/am.po (+83/-0)
po/ar.po (+84/-0)
po/ast.po (+86/-0)
po/az.po (+83/-0)
po/be.po (+84/-0)
po/bg.po (+86/-0)
po/bn.po (+85/-0)
po/bo.po (+87/-0)
po/bs.po (+84/-0)
po/ca.po (+88/-0)
po/ca@valencia.po (+88/-0)
po/ckb.po (+83/-0)
po/cs.po (+85/-0)
po/csb.po (+84/-0)
po/cy.po (+83/-0)
po/da.po (+87/-0)
po/de.po (+87/-0)
po/el.po (+87/-0)
po/en_AU.po (+84/-0)
po/en_GB.po (+84/-0)
po/eo.po (+83/-0)
po/es.po (+86/-0)
po/et.po (+85/-0)
po/eu.po (+86/-0)
po/fa.po (+84/-0)
po/fi.po (+87/-0)
po/fr.po (+87/-0)
po/gd.po (+87/-0)
po/gl.po (+87/-0)
po/gu.po (+83/-0)
po/he.po (+84/-0)
po/hi.po (+83/-0)
po/hr.po (+83/-0)
po/hu.po (+87/-0)
po/id.po (+83/-0)
po/is.po (+83/-0)
po/it.po (+85/-0)
po/ja.po (+83/-0)
po/kk.po (+83/-0)
po/kn.po (+87/-0)
po/ko.po (+83/-0)
po/ky.po (+83/-0)
po/lt.po (+86/-0)
po/lv.po (+83/-0)
po/ml.po (+83/-0)
po/mr.po (+83/-0)
po/ms.po (+84/-0)
po/my.po (+87/-0)
po/nb.po (+83/-0)
po/nl.po (+83/-0)
po/nn.po (+83/-0)
po/oc.po (+87/-0)
po/os.po (+84/-0)
po/pa.po (+83/-0)
po/pl.po (+83/-0)
po/pt.po (+86/-0)
po/pt_BR.po (+87/-0)
po/ro.po (+83/-0)
po/ru.po (+84/-0)
po/sk.po (+85/-0)
po/sl.po (+84/-0)
po/sq.po (+83/-0)
po/sr.po (+86/-0)
po/sv.po (+83/-0)
po/ta.po (+83/-0)
po/te.po (+87/-0)
po/tr.po (+86/-0)
po/ug.po (+85/-0)
po/uk.po (+87/-0)
po/unity_firefox_extension.pot (+28/-8)
po/uz.po (+84/-0)
po/vi.po (+86/-0)
po/zh_CN.po (+83/-0)
po/zh_HK.po (+83/-0)
po/zh_TW.po (+83/-0)
tests/testBradingRemover.js (+1/-1)
tests/testPreviewUtils.js (+12/-5)
tests/testStress.js (+67/-0)
unity-firefox-extension/bootstrap.js (+2/-4)
unity-firefox-extension/build.sh (+6/-2)
unity-firefox-extension/chrome.manifest (+65/-0)
unity-firefox-extension/content/exceptions.js (+2/-0)
unity-firefox-extension/content/exceptions.xul (+1/-2)
unity-firefox-extension/content/observer.js (+201/-1)
unity-firefox-extension/content/unity-api.js (+25/-8)
unity-firefox-extension/content/unity-global-property-initializer.js (+61/-106)
unity-firefox-extension/content/unity-popup-manager.js (+3/-3)
unity-firefox-extension/content/unity-view-manager.js (+0/-52)
unity-firefox-extension/content/unity-webapps.js (+555/-0)
unity-firefox-extension/content/unity-window-helper.js (+15/-8)
unity-firefox-extension/install.rdf (+2/-1)
unity-firefox-extension/locale/am/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/ar/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/ast/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/be/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/bg/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/bn/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/bo/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/bs/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/ca/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/ca@valencia/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/cs/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/cy/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/da/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/de/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/el/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/en-AU/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/en-GB/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/en-US/unity_webapps.properties (+5/-0)
unity-firefox-extension/locale/eo/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/es/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/eu/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/fa/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/fi/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/fr/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/gd/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/gl/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/gu/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/he/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/hr/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/hu/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/id/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/it/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/ja/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/kk/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/kn/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/ko/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/ky/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/lt/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/lv/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/ml/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/ms/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/my/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/nb/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/nl/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/nn/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/oc/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/os/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/pa/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/pl/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/pt-BR/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/pt/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/ro/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/ru-RU/unity_webapps.properties (+5/-0)
unity-firefox-extension/locale/ru/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/sk/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/sl/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/sq/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/sr/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/sv/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/ta/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/tr/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/ug/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/uk/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/vi/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/zh-CN/unity_webapps.properties (+0/-11)
unity-firefox-extension/locale/zh-HK/unity_webapps.properties (+16/-0)
unity-firefox-extension/locale/zh-TW/unity_webapps.properties (+0/-11)

CVE References

Ken VanDine (ken-vandine)
Changed in unity-firefox-extension (Ubuntu):
status: New → Fix Released
Changed in unity-firefox-extension (Ubuntu Quantal):
importance: Undecided → Medium
Robert Bruce Park (robru)
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Alexandre, or anyone else affected,

Accepted unity-firefox-extension into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/unity-firefox-extension/2.4.4-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in unity-firefox-extension (Ubuntu Quantal):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Tested using up-to-date Quantal, Firefox 19.0+build1-0ubuntu0.12.10.1 and xul-ext-unity 2.4.4-0ubuntu0.1

Test case:
1. Open http://launchpad.net/
2. Accept integration

Expected result:
- Launcher icon must be displayed.

Actual result: Works ok.

Test case:
1. Open http://ubuntuone.com/5rYjHq5Y1jJvlCt0xW6M5L
2. Accept integration.

Expected results:
- Launcher icon must be displayed.
- Launcher action "Sports" must be added.
- Notification must be shown.
- Sound menu entry must be displayed.
- Messaging menu entry must be displayed.

Actual results: Everything works ok.

Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-firefox-extension - 2.4.4-0ubuntu0.1

---------------
unity-firefox-extension (2.4.4-0ubuntu0.1) quantal-proposed; urgency=low

  * -debian/patches/CVE-2012-0958.patch
      - removed, merged upstream
  * -debian/patches/CVE-2012-0960
      - removed, merged upstream
  * New upstream release.
    - Crash when navigating to another page immediately
      after initializing unity integration (LP: #1076350).
    - Remove unity-webapps.js file generation for now. (LP: #1111732)
    - Add stress test.
    - Update to FF18.
    - Fix warnings.
 -- Robert Bruce Park <email address hidden> Wed, 30 Jan 2013 13:12:30 -0800

Changed in unity-firefox-extension (Ubuntu Quantal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.