Code duplication with dirspec
Bug #1016151 reported by
dobey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu One Client | Status tracked in Trunk | |||||
| Stable-4-0 |
Fix Released
|
Undecided
|
dobey | |||
| Trunk |
Fix Released
|
Undecided
|
dobey | |||
| Ubuntu One Control Panel | Status tracked in Trunk | |||||
| Stable-4-0 |
Fix Released
|
Undecided
|
dobey | |||
| Trunk |
Fix Released
|
Undecided
|
dobey | |||
| Ubuntu One Servers |
Triaged
|
Undecided
|
Unassigned | |||
| Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
| Stable-4-0 |
Fix Released
|
Undecided
|
dobey | |||
| Trunk |
Fix Released
|
Undecided
|
dobey | |||
| u1sync |
Fix Released
|
Undecided
|
dobey | |||
Bug Description
Now that we have dirspec, ubuntu-sso-client contains duplicate code in the xdg_base_directory utility package. However, as the version in ubuntu-sso-client is used by other projects, we must wait until those projects are converted, before removing it from sso.
Related branches
lp://staging/~dobey/u1sync/use-dirspec
- Brian Curtin (community): Approve
- Manuel de la Peña (community): Approve
-
Diff: 29 lines (+6/-3)1 file modifiedu1sync/client.py (+6/-3)
lp://staging/~dobey/ubuntuone-client/use-dirspec
- Brian Curtin (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 355 lines (+28/-73)16 files modifiedbin/ubuntuone-syncdaemon (+1/-1)
contrib/dump_metadata.py (+1/-1)
contrib/testing/testcase.py (+1/-1)
data/source_ubuntuone-client.py (+1/-1)
tests/platform/test_logger.py (+3/-5)
tests/syncdaemon/test_config.py (+2/-2)
tests/syncdaemon/test_main.py (+1/-1)
ubuntuone/platform/__init__.py (+2/-2)
ubuntuone/platform/credentials/__init__.py (+1/-4)
ubuntuone/platform/logger/__init__.py (+7/-0)
ubuntuone/platform/xdg_base_directory/__init__.py (+0/-40)
ubuntuone/proxy/logger.py (+1/-1)
ubuntuone/status/logger.py (+1/-4)
ubuntuone/syncdaemon/config.py (+2/-4)
ubuntuone/syncdaemon/logger.py (+1/-3)
ubuntuone/syncdaemon/main.py (+3/-3)
lp://staging/~dobey/ubuntuone-control-panel/use-dirspec
- Diego Sarmentero (community): Approve
- Manuel de la Peña (community): Approve
- Brian Curtin (community): Approve
-
Diff: 61 lines (+5/-5)5 files modifieddata/source_ubuntuone-control-panel.py (+1/-1)
ubuntuone/controlpanel/backend.py (+1/-1)
ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+1/-1)
ubuntuone/controlpanel/gui/qt/tests/test_systray.py (+1/-1)
ubuntuone/controlpanel/logger.py (+1/-1)
lp://staging/~dobey/ubuntu-sso-client/use-dirspec
- Manuel de la Peña (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 723 lines (+19/-515)17 files modifiedsetup.py (+2/-4)
ubuntu_sso/account.py (+2/-2)
ubuntu_sso/gtk/gui.py (+3/-3)
ubuntu_sso/keyring/tests/test_linux.py (+1/-1)
ubuntu_sso/logger.py (+2/-2)
ubuntu_sso/main/tests/test_linux.py (+1/-1)
ubuntu_sso/networkstate/darwin.py (+1/-1)
ubuntu_sso/networkstate/linux.py (+1/-1)
ubuntu_sso/qt/setup_account_page.py (+2/-2)
ubuntu_sso/qt/sso_wizard_page.py (+1/-1)
ubuntu_sso/qt/tests/test_common.py (+2/-2)
ubuntu_sso/tests/test_account.py (+1/-1)
ubuntu_sso/xdg_base_directory/__init__.py (+0/-104)
ubuntu_sso/xdg_base_directory/tests/__init__.py (+0/-29)
ubuntu_sso/xdg_base_directory/tests/test_common.py (+0/-91)
ubuntu_sso/xdg_base_directory/tests/test_windows.py (+0/-157)
ubuntu_sso/xdg_base_directory/windows.py (+0/-113)
| Changed in u1sync: | |
| assignee: | nobody → Rodney Dawes (dobey) |
| status: | New → In Progress |
| Changed in ubuntuone-servers: | |
| assignee: | nobody → Rodney Dawes (dobey) |
| status: | New → In Progress |
| Changed in u1sync: | |
| status: | In Progress → Fix Committed |
| Changed in u1sync: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntuone-servers: | |
| assignee: | Rodney Dawes (dobey) → nobody |
| status: | In Progress → Triaged |
To post a comment you must log in.
