Ubuntu One Files App for iOS

Switch positioning of "Share" and "Delete"

Bug #898458 reported by Danielle Foré on 2011-12-01

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Ubuntu One Files App for iOS	Fix Committed	Medium	Zachery Bir

Bug Description

In the U1 Files apps, Share is on the right and delete is on the left. However, in the default iOS apps share is always on the left and delete always on the right. (As seen in Notes, Photos, Voice Memos, etc)

It would probably be good, for the sake of consistency, to switch the positioning.

Roberto Alsina (ralsina) on 2012-01-16

Changed in ubuntuone-ios-files:
assignee:	nobody → Ubuntu One web team (ubuntuone-web)

Michał Karnicki (karni) on 2012-01-16

Changed in ubuntuone-ios-files:
assignee:	Ubuntu One web team (ubuntuone-web) → Ubuntu One iOS Client Team (ubuntuone-ios-client-team)

Rick McBride (rmcbride) on 2012-01-23

Changed in ubuntuone-ios-files:
status:	New → Confirmed

Revision history for this message

Tom Gall (tom-gall) wrote on 2012-04-09:

updated xib Edit (56.1 KiB, text/xml)

This updated xib addresses this bug by switching the share and delete bar button items. Since this is just a user interface update in the xib, there are no necessary updates to the logic in the U1FileDetailsViewController.[mh] code.

Revision history for this message

Tom Gall (tom-gall) wrote on 2012-04-09:

updated xib Edit (21.7 KiB, text/xml)

you want this file as well - changes around share and delete bar button items on U1FilePreviewController as well too.

Zachery Bir (urbanape) on 2012-04-24

Changed in ubuntuone-ios-files:
status:	Confirmed → In Progress
assignee:	Ubuntu One iOS Client Team (ubuntuone-ios-client-team) → Zachery Bir (urbanape)
importance:	Undecided → Medium

Revision history for this message

Zachery Bir (urbanape) wrote on 2012-04-27:

I kept the part where the buttons are switched, but left them plain and white for the time being. To match the UITabBar styling will take a bit more effort than just making the buttons Bordered. I also removed the left and right spacing, since apps like Photos have the Action and Delete buttons left- and right-aligned, respectively.