Ubuntu One Control Panel

Can launch duplicate instances

Bug #987909 reported by Ken VanDine
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu One Control Panel
Status tracked in Trunk
Stable-3-0
Fix Released
Undecided
Roberto Alsina
Ubuntu One Control Panel 3.0.1
Trunk
Fix Released
High
Roberto Alsina
ubuntuone-control-panel (Ubuntu)
Fix Released
Medium
Unassigned
Precise
Fix Released
Medium
Unassigned
Ubuntu precise-updates

Bug Description

Clicking on the Ubuntu One icon in the control-center or from the messaging menu launches multiple instances. This is inconsistent with the rest of the desktop apps and can cause problems. If you add a folder in one instance, it won't appear in the duplicate instances which could lead to bigger problems.

[Test Case]
1. Run ubuntuone-control-panel-qt
2. Run ubuntuone-control-panel-qt
3. Notice that without this fix, 2 control panels will open. With fix there will be only 1.

[Regression Potential]
Minimal. Unit tests updated with fix.

See original description

Related branches

lp://staging/~ralsina/ubuntuone-control-panel/unique_in_ubuntu
dobey (community): Approve
Diego Sarmentero (community): Approve
Diff: 284 lines (+67/-113)
8 files modified
run-tests (+1/-1)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+1/-0)
ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+13/-0)
ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py (+28/-8)
ubuntuone/controlpanel/gui/qt/uniqueapp/linux.py (+0/-29)
ubuntuone/controlpanel/gui/qt/uniqueapp/tests/test_unique_app.py (+2/-23)
ubuntuone/controlpanel/gui/qt/uniqueapp/windows.py (+0/-52)
ubuntuone/controlpanel/gui/tests/__init__.py (+22/-0)
lp://staging/~ralsina/ubuntuone-control-panel/unique-3-0
dobey (community): Approve
Diff: 284 lines (+67/-113)
8 files modified
run-tests (+1/-1)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+1/-0)
ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+13/-0)
ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py (+28/-8)
ubuntuone/controlpanel/gui/qt/uniqueapp/linux.py (+0/-29)
ubuntuone/controlpanel/gui/qt/uniqueapp/tests/test_unique_app.py (+2/-23)
ubuntuone/controlpanel/gui/qt/uniqueapp/windows.py (+0/-52)
ubuntuone/controlpanel/gui/tests/__init__.py (+22/-0)
lp://staging/ubuntu/quantal/ubuntuone-control-panel
lp://staging/ubuntu/precise-proposed/ubuntuone-control-panel
Revision history for this message
Ken VanDine (ken-vandine) wrote :
summary: - Can launch duplicate windows
+ Can launch duplicate instances
Changed in ubuntuone-control-panel (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
Roberto Alsina (ralsina)
Changed in ubuntuone-control-panel:
assignee: nobody → Roberto Alsina (ralsina)
status: New → In Progress
importance: Undecided → High
dobey (dobey)
Changed in ubuntuone-control-panel (Ubuntu Precise):
milestone: none → precise-updates
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 3.0.1-0ubuntu1.1

---------------
ubuntuone-control-panel (3.0.1-0ubuntu1.1) quantal; urgency=low

  * New upstream release.
    - Restore window properly when minimized to tray. (LP: #865688)
    - Make CalculateSize use bytes in os.walk. (LP: #959447)
    - Avoid obstruction of spin button hilights. (LP: #966283)
    - Fix external link buttons for RTL locales. (LP: #983665)
    - Avoid launching duplicate instances. (LP: #987909)
    - File sync status reports disabled while syncdaemon is IDLE. (LP: #995146)
  * debian/watch:
    - Update the watch file to use the stable-3-0 series
 -- Rodney Dawes <email address hidden> Tue, 22 May 2012 14:31:30 -0400

Changed in ubuntuone-control-panel (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Hello! This bug is attached to an upload in the queue for precise-proposed. However, it does not contain the requisite fields for the SRU team to process the upload. Please add them per the process outlined here. To be more succinct, make sure the bug description lists these fields: "Impact, Dev Fix, Stable Fix, Regression Potential, Test case".

https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

The upload will likely not be looked at by the SRU team until these fields are present.

Thank you!

dobey (dobey)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Ken, or anyone else affected,

Accepted ubuntuone-control-panel into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in ubuntuone-control-panel (Ubuntu Precise):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Rick McBride (rmcbride) wrote :

Verified behavior following:

1. Run ubuntuone-control-panel-qt
2. Run ubuntuone-control-panel-qt
3. Notice that without this fix, 2 control panels will open. With fix there will be only 1.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 3.0.1-0ubuntu1

---------------
ubuntuone-control-panel (3.0.1-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
    - Restore window properly when minimized to tray. (LP: #865688)
    - Make CalculateSize use bytes in os.walk. (LP: #959447)
    - Avoid obstruction of spin button hilights. (LP: #966283)
    - Fix external link buttons for RTL locales. (LP: #983665)
    - Avoid launching duplicate instances. (LP: #987909)
    - File sync status reports disabled while syncdaemon is IDLE. (LP: #995146)
  * debian/watch:
    - Update the watch file to use the stable-3-0 series
 -- Rodney Dawes <email address hidden> Tue, 22 May 2012 14:31:30 -0400

Changed in ubuntuone-control-panel (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.