Ubuntu One Client

broken syncdaemon.conf; improve the error handling

Bug #561936 reported by Jan Oetjen on 2010-04-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Ubuntu One Client	Confirmed	Low	Ubuntu One Foundations+ team

Bug Description

For reasons I don't know my syncdaemon.conf looks exactly like:

org/1999/02/22-rdf-syntax-ns#li> "iPod" .
<http://fakebase.f-spot.

which obviously is completly wrong. Unfortunately the Ubuntu One Client is missing some error checking when reading the file and crashes if I right click the icon. I simply fixed this by removing the config directory and letting the client generate a new one, but I think it would be a good idea to improve the error handling when the file is read in the client to prevent crashes.

Jan

P.S.: I attached the broken syncdaemon.conf

Tags:

Revision history for this message

Jan Oetjen (joetjen) wrote on 2010-04-13:

broken syncdaemon.conf Edit (66 bytes, text/plain)

Duane Hinnen (duanedesign) on 2010-04-13

summary:

- broken syncdaemon.conf
+ broken syncdaemon.conf; improve the error handling

Facundo Batista (facundo) on 2010-05-17

tags:

added: chicharra chicharra-maverick

Facundo Batista (facundo) on 2010-05-19

Changed in ubuntuone-client:
importance:	Undecided → High
importance:	High → Medium

Facundo Batista (facundo) on 2010-11-11

tags:

added: chicharra-natty
removed: chicharra-maverick

Roberto Alsina (ralsina) on 2011-02-04

Changed in ubuntuone-client:
assignee:	nobody → Ubuntu One Foundations+ team (ubuntuone-foundations+)
assignee:	Ubuntu One Foundations+ team (ubuntuone-foundations+) → nobody

Roberto Alsina (ralsina) on 2011-02-04

Changed in ubuntuone-client:
assignee:	nobody → Roberto Alsina (ralsina)

Revision history for this message

Roberto Alsina (ralsina) wrote on 2011-02-04:

I confirmed it on Maverick and Natty, version:

ii ubuntuone-client 1.5.3+r839~natty1

If I create a garbage syncdaemon.conf, it fails with this error:

Traceback (most recent call last):
  File "/usr/lib/ubuntuone-client/ubuntuone-syncdaemon", line 187, in <module>
    main(sys.argv)
  File "/usr/lib/ubuntuone-client/ubuntuone-syncdaemon", line 74, in main
    args=args, usage=usage)
  File "/usr/lib/pymodules/python2.7/ubuntuone/syncdaemon/config.py", line 375, in configglue
    cp.read(filenames)
  File "/usr/lib/python2.7/ConfigParser.py", line 297, in read
    self._read(fp, filename)
  File "/usr/lib/python2.7/ConfigParser.py", line 504, in _read
    raise MissingSectionHeaderError(fpname, lineno, line)
ConfigParser.MissingSectionHeaderError: File contains no section headers.
file: /home/ralsina/.config/ubuntuone/syncdaemon.conf, line: 1

Changed in ubuntuone-client:
status:	New → Confirmed
assignee:	Roberto Alsina (ralsina) → Ubuntu One Foundations+ team (ubuntuone-foundations+)
importance:	Medium → Low