Contact Picker - Search string not highlighted in contact names
Bug #551580 reported by
John Lea
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
Undecided
|
Alejandro J. Cura |
Bug Description
In response to each letter being typed, the search sting should be highlighted in contact names. e.g. If I have a contact named "joe blogs" and I type "o" into the search field the letter "o" should be instantly made bold in the name ("jOe blOgs"). See specification (step 8 of primary scenairo) - http://
Related branches
lp://staging/~alecu/ubuntuone-client/highlight-search
- Rodrigo Moya (community): Approve
- John Lenton (community): Approve
-
Diff: 554 lines (+325/-14)6 files modified.bzrignore (+1/-0)
nautilus/Makefile.am (+13/-1)
nautilus/contacts-view.c (+28/-13)
nautilus/highlight.c (+161/-0)
nautilus/highlight.h (+29/-0)
nautilus/test-highlight.c (+93/-0)
Changed in ubuntuone-client: | |
assignee: | nobody → Rodrigo Moya (rodrigo-moya) |
tags: |
added: u1-maverick removed: u1-lucid |
Changed in ubuntuone-client: | |
assignee: | Rodrigo Moya (rodrigo-moya) → nobody |
Changed in ubuntuone-client: | |
status: | New → Confirmed |
tags: | added: contacts-picker desktop+ |
Changed in ubuntuone-client: | |
assignee: | nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+) |
Changed in ubuntuone-client: | |
assignee: | Ubuntu One Desktop+ team (ubuntuone-desktop+) → Alejandro J. Cura (alecu) |
To post a comment you must log in.
I think we probably want to only actually do a search when 3 characters have been typed in. Most software that does automatic search behaves this way (waiting for 3 characters), as single character searches often end up matching nearly every entry in one's contacts list.
There is of course exception to this rule for languages such as Mandarin, where a person's name may be only one character.