When several snaps are being installed, cancelling an installation does not cancel the right one.

Bug #1722183 reported by Jean-Baptiste Lallement
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME Software
Fix Released
Medium
gnome-software (Ubuntu)
Fix Released
High
Robert Ancell
Zesty
Triaged
High
Unassigned
Artful
Fix Released
High
Robert Ancell
Bionic
Fix Released
High
Robert Ancell

Bug Description

gnome-software 3.26.1-0ubuntu1~ppa1

Test Case
1. Install several snaps successively (from the main page, click on a snap, install, go back and repeat several times)
2. Select a snap and cancel the installation

Expected result:
The snap that is cancelled is cancelled and not another one.

Actual result
For example, install atom, brackets, discord, wavebox, heroku. Cancel discord and observe that wavebox is cancelled instead.

ProblemType: Bug
DistroRelease: Ubuntu 17.10
Package: gnome-software 3.26.0-0ubuntu3
ProcVersionSignature: Ubuntu 4.13.0-12.13-generic 4.13.3
Uname: Linux 4.13.0-12-generic x86_64
ApportVersion: 2.20.7-0ubuntu2
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon Oct 9 10:42:21 2017
InstallationDate: Installed on 2013-09-03 (1496 days ago)
InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Alpha amd64 (20130902)
InstalledPlugins:
 gnome-software-plugin-flatpak N/A
 gnome-software-plugin-limba N/A
 gnome-software-plugin-snap 3.26.0-0ubuntu3
ProcEnviron:
 TERM=screen-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=fr_FR.UTF-8
 SHELL=/bin/bash
SourcePackage: gnome-software
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :
Will Cooke (willcooke)
Changed in gnome-software (Ubuntu Artful):
assignee: nobody → Robert Ancell (robert-ancell)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Can you confirm if this is a new bug or an existing one?

Changed in gnome-software (Ubuntu Artful):
status: New → Triaged
importance: Undecided → High
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote : Re: [Bug 1722183] Re: When several snaps are being installed, cancelling an installation does not cancel the right one.

Le 10/10/2017 à 05:29, Robert Ancell a écrit :
> Can you confirm if this is a new bug or an existing one?
I'd say 'new' because it cannot be done with the current version due to
another bug (There is an error when you install a second snap and g-s
thinks it is not installed so you cannot cancel)

>
> ** Changed in: gnome-software (Ubuntu Artful)
> Status: New => Triaged
>
> ** Changed in: gnome-software (Ubuntu Artful)
> Importance: Undecided => High
>

--
Jean-Baptiste Lallement
irc: jibel

tags: added: gnome-software-snap
Changed in snapd-glib (Ubuntu Bionic):
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Robert Ancell (robert-ancell)
Changed in snapd-glib (Ubuntu Artful):
assignee: nobody → Robert Ancell (robert-ancell)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package snapd-glib - 1.24-0ubuntu1

---------------
snapd-glib (1.24-0ubuntu1) bionic; urgency=medium

  * New upstream release:
    - Fix QSnapd::install() not working async.
    - Move Qt enums to an enum class and rename to avoid collisions (API break).
    - Fix multiple async operations not working at the same time. (LP: #1722183)
    - When async requests are cancelled abort change in snapd. (LP: #1721762)
    - Connect to snapd on demand. (LP: #1723874)
    - Add ability to set snapd socket to connect to.
    - Add support for channels.
    - Fix runtime assertion when snapd socket is NULL.
    - Fix sudoer flag not being correctly set for create-user.
    - Make clients using provided sockets non-blocking.
    - Don't install snapd-qt.pc if not compiling snapd-qt.
  * debian/libsnapd-glib1.symbols:
  * debian/libsnapd-qt1.symbols:
    - Updated

 -- Robert Ancell <email address hidden> Thu, 26 Oct 2017 12:40:05 +1300

Changed in snapd-glib (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Robert Ancell (robert-ancell) wrote :

That upload didn't fix this problem, still investigating...

Changed in snapd-glib (Ubuntu Bionic):
status: Fix Released → New
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Confirmed the bug is in core GNOME Software (i.e. not the snap plugin on snapd-glib).

no longer affects: snapd-glib (Ubuntu)
no longer affects: snapd-glib (Ubuntu Artful)
no longer affects: snapd-glib (Ubuntu Bionic)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Note the UI didn't support cancelling in Xenial.

Changed in gnome-software (Ubuntu Zesty):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Robert Ancell (robert-ancell)
Changed in gnome-software:
importance: Unknown → Medium
status: Unknown → Confirmed
Changed in gnome-software (Ubuntu Artful):
status: Triaged → Fix Released
status: Fix Released → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.26.1-0ubuntu6

---------------
gnome-software (3.26.1-0ubuntu6) bionic; urgency=medium

  * debian/patches/0001-Add-a-cancellable-to-GsApp-objects.patch:
  * debian/patches/0001-Allow-to-cancel-app-ops-in-the-details-view-that-wer.patch:
    - Fix cancelling with multiple installs (LP: #1722183)

 -- Robert Ancell <email address hidden> Fri, 03 Nov 2017 11:42:47 +1300

Changed in gnome-software (Ubuntu Bionic):
status: Triaged → Fix Released
Changed in gnome-software:
status: Confirmed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Jean-Baptiste, or anyone else affected,

Accepted gnome-software into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.26.1-0ubuntu2.17.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed verification-needed-artful
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Artful:
I have reproduced the problem with gnome-software 3.26.1-0ubuntu2 in artful and have verified that the version of gnome-software 3.26.1-0ubuntu2.17.10.1 in -proposed fixes the issue.

Marking as verification-done

tags: added: verification-done-artful
removed: verification-needed-artful
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.26.1-0ubuntu2.17.10.1

---------------
gnome-software (3.26.1-0ubuntu2.17.10.1) artful; urgency=medium

  [ Robert Ancell ]
  * debian/patches/0001-snap-Don-t-crash-on-unknown-snap-types.patch:
    - Fix crash when broken snaps installed (LP: #1720442)
  * debian/patches/0001-snap-Protect-store-cache-with-a-lock.patch:
    - Fix crash due to multiple threads accessing a cache (LP: #1716633)
  * debian/patches/0001-snap-Don-t-attempt-to-refine-snaps-without-a-valid-n.patch:
    - Fix potential crash from invalid snaps
  * debian/patches/0001-snap-Remove-unused-variables.patch:
    - Trivial patch added to make above patches apply cleanly
  * debian/patches/0001-Add-a-cancellable-to-GsApp-objects.patch:
  * debian/patches/0001-Allow-to-cancel-app-ops-in-the-details-view-that-wer.patch:
    - Fix cancelling with multiple installs (LP: #1722183)
  * debian/control:
    - Add Vcs-Bzr link

  [ Jeremy Bicha ]
  * Cherry-pick 0001-Don-t-error-out-for-over-500-results.patch:
    - Fix empty Addons > Shell Extensions category (LP: #1722809)

 -- Robert Ancell <email address hidden> Wed, 15 Nov 2017 11:58:57 +1300

Changed in gnome-software (Ubuntu Artful):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in gnome-software (Ubuntu Zesty):
assignee: Robert Ancell (robert-ancell) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.