GtkToolButtons clip and overlap

Bug #1641915 reported by Martin Wimpress 
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu theme
Fix Released
Low
Unassigned
ubuntu-themes (Ubuntu)
Fix Released
Low
Unassigned
Xenial
In Progress
Low
Unassigned

Bug Description

[ Impact ]

GtkToolButton styling causes buttons to clip and overlap each other. This
can be seen in gnome-disks and the Ubiquity disk partitioner for Ubuntu 16.04.1. See the attached screenshot:

  * https://bugs.launchpad.net/ubuntu-themes/+bug/1641915/+attachment/4777652/+files/gtk-toolbutton-clipping.png

[ Test Case ]

Start a Ubuntu 16.04.1 live session and "Try Ubuntu". From the live Desktop click the Ubuntu logo in the launcher, search for Disks and start it. Select the hard disk from the side panel, then look at and hover over, the buttons beneath the representation of the disk partitions. You'll notice the buttons clip/overlap as illustrated in the screenshot above.

Now double click the "Install Ubuntu 16.04.1 LTS" icon on the desktop. The Installer will start, click Continue, click Continue, check "Something else" and then the click Continue. Look at, and hover over, the buttons beneath the tree representing the disk partitions. You'll notice they clip/overlap as illustrated in the screenshot above.

After the patched ubuntu-themes has been installed the buttons described in the steps above will no longer clip/overlap.

[ Regression Potential ]

None expected.

[ Other Info ]

This issue does not present in Yakkety or Zesty.

Related branches

Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :
Changed in ubuntu-themes:
status: New → In Progress
assignee: nobody → Martin Wimpress (flexiondotorg)
Changed in ubuntu-themes (Ubuntu):
assignee: nobody → Martin Wimpress (flexiondotorg)
status: New → In Progress
Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

This following branch fixes this issue in Xenial:

  * lp:~flexiondotorg/ubuntu-themes/ubuntu-themes-gtktoolbutton-lp1641915-xenial

The attached screen shot illustrates the fix.

Changed in ubuntu-themes (Ubuntu):
assignee: Martin Wimpress (flexiondotorg) → nobody
status: In Progress → Fix Released
Changed in ubuntu-themes (Ubuntu Xenial):
status: New → In Progress
importance: Undecided → Low
assignee: nobody → Martin Wimpress (flexiondotorg)
description: updated
description: updated
summary: - GtkToolButton styling clips and overlaps
+ GtkToolButtons clip and overlap
Mathew Hodson (mhodson)
Changed in ubuntu-themes (Ubuntu):
importance: Undecided → Low
Revision history for this message
Brian Murray (brian-murray) wrote :

Why does this not present in Yakkety or Zesty? Is it fixed there if so how?

Additionally, the regression potential section of the bug description should be about how a regression may manifest that way testers and the SRU team know what to look for.

Changed in ubuntu-themes (Ubuntu Xenial):
status: In Progress → Incomplete
Changed in ubuntu-themes (Ubuntu Xenial):
status: Incomplete → New
assignee: Martin Wimpress (flexiondotorg) → nobody
Changed in ubuntu-themes:
assignee: Martin Wimpress (flexiondotorg) → nobody
Changed in ubuntu-themes (Ubuntu Xenial):
status: New → Incomplete
Revision history for this message
Will Cooke (willcooke) wrote :

We should SRU this fix to Xenial.

Changed in ubuntu-themes (Ubuntu Xenial):
status: Incomplete → Confirmed
tags: added: rls-aa-incoming
Revision history for this message
Robie Basak (racb) wrote :

Unsubscribing ~ubuntu-sponsors pending a response to Laney's review comments in https://code.launchpad.net/~flexiondotorg/ubuntu-themes/ubuntu-themes-gtktoolbutton-lp1641915-xenial/+merge/310889.

Once this is believed to be ready for upload again, please resubscribe ~ubuntu-sponsors.

Revision history for this message
Amr Ibrahim (amribrahim1987) wrote :

Ping!

Changed in ubuntu-themes (Ubuntu Xenial):
assignee: nobody → Martin Wimpress (flexiondotorg)
status: Confirmed → In Progress
Changed in ubuntu-themes:
status: In Progress → Fix Released
importance: Undecided → Low
Changed in ubuntu-themes (Ubuntu Xenial):
assignee: Martin Wimpress (flexiondotorg) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.