rt-tests backfire dkms module fails to build on ppc64el
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-kernel-tests |
New
|
Undecided
|
Sultan Alsawaf | ||
rt-tests (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Confirmed
|
Undecided
|
Unassigned |
Bug Description
An update to the powerpc arch in xenial/linux-hwe exposed a bug in the backfire dkms module in rt-tests. The backfire dkms module fails to build with the following error:
---
make: Entering directory '/usr/src/
CC [M] /var/lib/
In file included from ./include/
./arch/
./arch/
if (likely(
./include/
# define likely(x) __builtin_
./arch/
if (likely(
^
./arch/
if (likely(
./include/
# define likely(x) __builtin_
./arch/
if (likely(
^
./arch/
(__chk_
./include/
# define likely(x) __builtin_
./arch/
if (likely(
^
scripts/
make[1]: *** [/var/lib/
Makefile:1571: recipe for target '_module_
make: *** [_module_
make: Leaving directory '/usr/src/
---
This occurs because backfire.c includes arch-specific uaccess.h headers directly (via "#include <asm/uaccess.h>"), which is incorrect because arch-specific uaccess.h can have dependencies on the linux/uaccess.h header. The linux/uaccess.h header includes asm/uaccess.h, so the fix is to replace "#include <asm/uaccess.h>" with "#include <linux/uaccess.h>" in the backfire.c file.
tags: | added: ppc64el |
Changed in rt-tests (Ubuntu Xenial): | |
status: | New → Confirmed |
Changed in rt-tests (Ubuntu): | |
status: | New → Fix Released |