FTBFS on Xenial and Yakkety due to nm-version-macros.h

Bug #1630462 reported by Christian Ehrhardt 
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
nis (Ubuntu)
Fix Released
Medium
Unassigned
Xenial
Confirmed
Low
Unassigned
Yakkety
Confirmed
Low
Unassigned

Bug Description

While trying to rebuild yesterday I found:

In file included from ypbind_dbus_nm.c:34:0:
/usr/include/NetworkManager/NetworkManager.h:31:31: fatal error: nm-version-macros.h: No such file or directory
 #include <nm-version-macros.h>
                               ^

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Not to be confused this is part of two packages:
network-manager-dev:amd64: /usr/include/NetworkManager/nm-version-macros.h
libnm-dev:amd64: /usr/include/libnm/nm-version-macros.h

The first already being a build dependency of nis.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Repro in nis with:
cd ./ypbind-mt-1.20.1/src/

x86_64-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -D_REENTRANT=1 -Wall -DUSE_BROADCAST=1 -DLOCALEDIR=\"/usr/share/locale\" -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -O0 -Wall -g -MT ypbind_dbus_nm.o -MD -MP -MF .deps/ypbind_dbus_nm.Tpo -c -o ypbind_dbus_nm.o ypbind_dbus_nm.c

Kind of related to https://mail.gnome.org/archives/networkmanager-list/2016-January/msg00029.html

Adding a proper
-I/usr/include/NetworkManager
and including as
#include <NetworkManager.h>
would fix that.

But there might be more.
The latest upstream seems to have made plenty of changes around that.
Debian merged that recently lifting e.g. yp-tools from 1.20 to 1.38 which is a huge change.
 56 files changed, 5902 insertions(+), 3493 deletions(-)

The "offending" commit to NetworkManager is:
commit 780e9a3f436b5bb347275e1951f45a487b153e11
Author: Thomas Haller <email address hidden>
Date: Fri Jul 17 15:45:10 2015 +0200
    libnm: include header in public header file with angle brackets

It seems time for a bigger merge next cycle but I don't know about the X/Y FTBFS yet.
nis is "only" universe - anybody having time to create and test a fix please feel free.
Putting it to the backlog for now.

Changed in nis (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Updated are so rare that we better fix this as-needed on any next update, also it is ok in latter versions - therefore marking appropriately and unsubscribing ubuntu-server.

Changed in nis (Ubuntu):
status: Triaged → Fix Released
Changed in nis (Ubuntu Xenial):
status: New → Confirmed
Changed in nis (Ubuntu Yakkety):
status: New → Confirmed
Changed in nis (Ubuntu Xenial):
importance: Undecided → Low
Changed in nis (Ubuntu Yakkety):
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.