lttng-modules/2.13.1-1 ADT test failure with linux/5.15.0-47.51

This is caused by upstream dropping trace points in random (again). That change got backported to v5.15.44. There is an upstream fix for lttng-modules which needs to be applied to fix this:

commit ed1149ef
Author: Michael Jeanson <email address hidden>
Date: Tue May 31 15:24:48 2022 -0400

    fix: 'random' tracepoints removed in stable kernels

Upstream fixed this by doing a build-time check for the random.h file. This requires doing the same to decide whether the resulting module should be considered by the DKMS build.

I did run above changes for 5.15.0-46 and -47. Both work and -46 also installs lttng-probe-random.

This issue can be found on F-5.15 as well.

These are the changes from jammy backported to focal. I have test-compiled this on focal with the current kernel to double check things work and produce the lttng-probe-random.ko module still.

Hello Stefan, or anyone else affected,

Accepted lttng-modules into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lttng-modules/2.13.1-1ubuntu0.22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Hello Stefan, or anyone else affected,

Accepted lttng-modules into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lttng-modules/2.12.5-1ubuntu2~20.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

For jammy this was failing before in ADT with the kernel in proposed and is now succeeding: https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/amd64/l/lttng-modules/20220823_160451_66a2c@/log.gz

For focal we can only test the current kernel (hwe-5.15 has not yet picked up the lastest jammy changes because of the upcoming point release): https://autopkgtest.ubuntu.com/results/autopkgtest-focal/focal/amd64/l/lttng-modules/20220823_163854_772ca@/log.gz

This bug was fixed in the package lttng-modules - 2.13.1-1ubuntu0.22.04.1

---------------
lttng-modules (2.13.1-1ubuntu0.22.04.1) jammy; urgency=medium

  * [ed1149ef] Backport upstream fix to handle removal of random.h
    (LP: #1986921)

 -- Stefan Bader <email address hidden> Thu, 18 Aug 2022 10:13:02 +0200

The verification of the Stable Release Update for lttng-modules has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

> For focal we can only test the current kernel (hwe-5.15 has not yet picked up the lastest jammy changes because of the upcoming point release)

It seems odd to release an SRU without the ability to test what it is fixing. If it turns out not to fix it, we'd have to be doing an SRU again for no good reason.

Can this wait until it can be tested properly?

> Can this wait until it can be tested properly?

Actually this is now. Because the changes not only went into 5.15 but this cycle also into 5.4. See the proposed run compared to current version for the -126 kernel.

https://autopkgtest.ubuntu.com/packages/l/lttng-modules/focal/amd64

I can see this issue with B-5.4 lttng-modules-dkms 2.10.8-1ubuntu2~18.04.3 as well.

/var/lib/dkms/lttng-modules/2.10.8/build/probes/lttng-probe-random.c:31:10: fatal error: trace/events/random.h: No such file or directory

This bug was fixed in the package lttng-modules - 2.12.5-1ubuntu2~20.04.3

---------------
lttng-modules (2.12.5-1ubuntu2~20.04.3) focal; urgency=medium

  * [ed1149ef] Backport upstream fix to handle removal of random.h
    The change was backported to v5.15.44 by upstream stable and will
    break the build for focal:linux-hwe-5.15. (LP: #1986921)

 -- Stefan Bader <email address hidden> Tue, 23 Aug 2022 11:04:49 +0200

Fix for the 5.4 kernel in bionic reported in attach.

sponsored into bionic-proposed unapproved queue

Hello Stefan, or anyone else affected,

Accepted lttng-modules into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lttng-modules/2.10.8-1ubuntu2~18.04.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Verified on B-aws-5.4, DKMS can be installed without any issue and test works just fine.
Thanks!

Confirming the fix also works with bionic/linux-hwe-5.4 which builds for all arches:

* amd64 - https://autopkgtest.ubuntu.com/results/autopkgtest-bionic/bionic/amd64/l/lttng-modules/20220914_114635_72fb4@/log.gz
* arm64 - https://autopkgtest.ubuntu.com/results/autopkgtest-bionic/bionic/arm64/l/lttng-modules/20220914_114634_72fb4@/log.gz
* armhf - https://autopkgtest.ubuntu.com/results/autopkgtest-bionic/bionic/armhf/l/lttng-modules/20220914_114745_97a52@/log.gz
* i386 - https://autopkgtest.ubuntu.com/results/autopkgtest-bionic/bionic/i386/l/lttng-modules/20220914_114744_e64ab@/log.gz
* ppc64el - https://autopkgtest.ubuntu.com/results/autopkgtest-bionic/bionic/ppc64el/l/lttng-modules/20220914_114632_72fb4@/log.gz
* s390x - https://autopkgtest.ubuntu.com/results/autopkgtest-bionic/bionic/s390x/l/lttng-modules/20220914_114552_72fb4@/log.gz

Okay, as this is needed for the new batch of kernels, is verified and no errors related to the package seem to be present in errors.ubuntu.com, let me release this earlier.

This bug was fixed in the package lttng-modules - 2.10.8-1ubuntu2~18.04.4

---------------
lttng-modules (2.10.8-1ubuntu2~18.04.4) bionic; urgency=medium

  * Backport upstream fix to handle removal of random tracepoints in the
    kernel (LP: #1986921):
    - d/p/compat-5.4/0001-support-kernels-without-random-tracepoints.patch

 -- Andrea Righi <email address hidden> Thu, 08 Sep 2022 08:14:15 +0000

Hints removed, thanks!

Spotted on X-hwe 4.15.0-194.205~16.04.1

 /var/lib/dkms/lttng-modules/2.8.0/build/probes/lttng-probe-random.c:31:33: fatal error: trace/events/random.h: No such file or directory
 compilation terminated.
 scripts/Makefile.build:340: recipe for target '/var/lib/dkms/lttng-modules/2.8.0/build/probes/lttng-probe-random.o' failed
 make[2]: *** [/var/lib/dkms/lttng-modules/2.8.0/build/probes/lttng-probe-random.o] Error 1
 scripts/Makefile.build:607: recipe for target '/var/lib/dkms/lttng-modules/2.8.0/build/probes' failed
 make[1]: *** [/var/lib/dkms/lttng-modules/2.8.0/build/probes] Error 2
 Makefile:1590: recipe for target '_module_/var/lib/dkms/lttng-modules/2.8.0/build' failed
 make: *** [_module_/var/lib/dkms/lttng-modules/2.8.0/build] Error 2
 make: Leaving directory '/usr/src/linux-headers-4.15.0-194-generic'