Ubuntu
distro-info package

[SRU] Please backport UbuntuDistroInfo().get_all(result="object") to Xenial

Xenial (16.04)
Bug #2029089

Bug #2029089 reported by Nathan Teodosio on 2023-07-31

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	distro-info (Ubuntu)	Triaged	Undecided	Unassigned
	Xenial	Fix Committed	High	Nathan Teodosio

Bug Description

I'm working on a update to software-properties in 16.04 to support the Ubuntu Pro tab. That work was already released to >=18.04, containing, for example, in commit "Show extended security maintenance status"[1]:

```python
def current_distro():
    distro = aptsources.distro.get_distro()
    di = distro_info.UbuntuDistroInfo()
    releases = di.get_all(result="object")
    [...]
```

That is functionality introduced in versions 0.15 and 0.16 of distro-info, for which Xenial didn't receive a backport yet.

Test Plan
---------

1. Install the update.
2. Verify that running this in a shell prints a list of a correct list of EOL date (in YY-MM-DDDD format) and distribution name to the standard output:

--->
python3 <<EOF | sort -n
import distro_info
for d in distro_info.UbuntuDistroInfo().get_all(result="object"):
print("%s %s" % (d.eol, d.codename))
EOF
<---

Regression potential
--------------------

If something were wrong with this update, reverse dependencies could misidentify a given release, e.g. by incorrectly assessing a user release as supported or no longer supported, LTS or non-LTS etc..

[1] https://git.launchpad.net/software-properties/commit/?h=ubuntu/bionic&id=c2bb1f8eeb70e2a9c4b40f326d21c287dec1baa8

See original description

Tags:

Benjamin Drung (bdrung) on 2023-07-31

description:	updated
summary:	- Please backport changes to Xenial + Please backport UbuntuDistroInfo().get_all(result="object") to Xenial

Revision history for this message

Benjamin Drung (bdrung) wrote on 2023-07-31: Re: Please backport UbuntuDistroInfo().get_all(result="object") to Xenial

distro-info_0.14ubuntu0.3.debdiff Edit (9.9 KiB, text/plain)

Debdiff of xenial attached.

Ubuntu Foundations Team Bug Bot (crichton) on 2023-07-31

tags:

added: patch

Revision history for this message

Thomas Ward (teward) wrote on 2023-08-01 (last edit on 2023-08-01):

This needs special handling / consideration from the Canonical teams and the Release team before this can be added.

Xenial has already left End of Standard Support, so the Release and Canonical teams need to decide if they want to out-of-band update/patch this.

Changed in distro-info (Ubuntu):
status:	New → Incomplete

Revision history for this message

Robie Basak (racb) wrote on 2023-08-01:

We have an exception for ubuntu-advantage-tools because it provides the "gateway" to Pro for users - without that we'd end up with a circular problem that would just make it difficult for users to initially enable Pro.

I think probably that also should apply to other packages involved in providing that gateway. It sounds like this should qualify. I'll ask to see if there's SRU team consensus on this.

Revision history for this message

Robie Basak (racb) wrote on 2023-08-03 (last edit on 2023-08-03):

SRU team opinion seems to be that on the question of updating xenial-updates after EOSS, this is fine in principle in this case for the reason above. Note that this is subject to review of the actual upload - it should be trivial and straightforward; I haven't reviewed the debdiff itself.

Robie Basak (racb) on 2023-08-03

Changed in distro-info (Ubuntu):
status:	Incomplete → Triaged

Nathan Teodosio (nteodosio) on 2023-08-03

description:	updated
Changed in distro-info (Ubuntu Xenial):
status:	New → Triaged
importance:	Undecided → High
summary:	- Please backport UbuntuDistroInfo().get_all(result="object") to Xenial + [SRU] Please backport UbuntuDistroInfo().get_all(result="object") to + Xenial

Nathan Teodosio (nteodosio) on 2023-08-03

description:

updated

Revision history for this message

Brian Murray (brian-murray) wrote on 2023-08-11:

While testing this update as a part of the sponsorship process I noticed that the eol-esm date for Ubuntu 16.04 is incorrect in the version of ubuntu.csv included with distro-info-data for Ubuntu 16.04 so that will likely need an update too.

(xenial-amd64)root@impulse:/home/bdmurray/tmp# grep xenial /usr/share/distro-info/ubuntu.csv
16.04 LTS,Xenial Xerus,xenial,2015-10-22,2016-04-21,2021-04-21,2021-04-21,2024-04-23

Revision history for this message

Brian Murray (brian-murray) wrote on 2023-08-11:

I've gone ahead and sponsored this debdiff for Xenial. Thanks!

Changed in distro-info (Ubuntu Xenial):
status:	Triaged → In Progress
assignee:	nobody → Nathan Teodosio (nteodosio)

Revision history for this message

Benjamin Drung (bdrung) wrote on 2023-08-11:

Oh, right. Thanks Brian. dput-ng refused to upload to xenial and I failed fighting against it.

Revision history for this message

Robie Basak (racb) wrote on 2023-08-16:

Accepting into xenial-proposed. However, before marking verification-done-xenial, please also get your software-properties update into xenial-proposed and also verified, so that we are testing and landing everything together, so that we do not end up iterating in xenial-updates if something here needs tweaking and it's only detected when trying to land the full user story.

Revision history for this message

Robie Basak (racb) wrote on 2023-08-16:

(if necessary that would mean a versioned Depends from the updated software-properties to the new distro-info in xenial-updates, which would seem appropriate).

Changed in distro-info (Ubuntu Xenial):
status:	In Progress → Fix Committed
tags:	added: verification-needed verification-needed-xenial

Revision history for this message

Robie Basak (racb) wrote on 2023-08-16: Please test proposed package

#10

Hello Nathan, or anyone else affected,

Accepted distro-info into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/distro-info/0.14ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message

Ubuntu SRU Bot (ubuntu-sru-bot) wrote on 2023-08-16: Autopkgtest regression report (distro-info/0.14ubuntu0.3)

#11

All autopkgtests for the newly accepted distro-info (0.14ubuntu0.3) for xenial have finished running.
The following regressions have been reported in tests triggered by the package:

juju-core/unknown (armhf)
update-notifier/unknown (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/xenial/update_excuses.html#distro-info

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message

Sebastien Bacher (seb128) wrote on 2023-08-30:

#12

the autopkgtest failing jobs worked on a retry