Connect to XDMCP clients on address requests come from if available
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Light Display Manager |
Fix Released
|
Medium
|
Unassigned | ||
1.10 |
Fix Committed
|
Medium
|
Unassigned | ||
1.14 |
Fix Released
|
Medium
|
Unassigned | ||
1.2 |
Fix Committed
|
Medium
|
Unassigned | ||
lightdm (Ubuntu) |
Fix Released
|
Medium
|
Robert Ancell | ||
Precise |
Won't Fix
|
Medium
|
Unassigned | ||
Trusty |
Fix Released
|
Medium
|
Robert Ancell | ||
Vivid |
Fix Released
|
Medium
|
Robert Ancell | ||
Wily |
Fix Committed
|
Medium
|
Unassigned |
Bug Description
[Impact]
Currently LightDM connects to an XDMCP enabled X server using the first suitable address in the XDMCP Request packet. However, some clients may put a number of addresses in this message and potentially they are not all routable. If the address the request message came from is in the list we should use that first as that is more likely to be a routable address. This also matches the behaviour of GDM which ignores the contents of the Request packet anyway.
[Test Case]
1. Start LightDM with XDMCP enabled
2. Connect with a client that puts a number of addresses in the Request packet
Expected result:
LightDM prefers the address the Request came from over the other addresses.
Observed result:
LightDM always picks the first address.
[Regression Potential]
There is a possibility of a behaviour change in existing clients that had two valid addresses, though the particular address shouldn't matter (unless complex firewalling / routing rules are being used). There is a risk that XDMCP behaviour could have been broken by the change (tested with regression tests).
Changed in lightdm: | |
status: | New → Triaged |
importance: | Undecided → Medium |
status: | Triaged → Fix Committed |
Changed in lightdm: | |
milestone: | none → 1.15.2 |
Changed in lightdm: | |
milestone: | 1.15.2 → 1.15.1 |
Changed in lightdm: | |
status: | Fix Committed → Fix Released |
description: | updated |
Changed in lightdm (Ubuntu Vivid): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in lightdm (Ubuntu): | |
importance: | Undecided → Medium |
Changed in lightdm (Ubuntu Vivid): | |
status: | Triaged → In Progress |
assignee: | nobody → Robert Ancell (robert-ancell) |
tags: |
added: verification-done-vivid removed: verification-needed |
tags: |
added: verification-failed removed: verification-done-vivid |
Changed in lightdm (Ubuntu Wily): | |
status: | New → Fix Committed |
Changed in lightdm (Ubuntu Trusty): | |
status: | New → Fix Committed |
importance: | Undecided → Medium |
Changed in lightdm (Ubuntu Wily): | |
importance: | Undecided → Medium |
Changed in lightdm (Ubuntu Precise): | |
importance: | Undecided → Medium |
tags: |
added: verification-done-trusty verification-needed-vivid removed: verification-needed |
Changed in lightdm (Ubuntu Trusty): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
Changed in lightdm (Ubuntu Wily): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
Changed in lightdm (Ubuntu): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
tags: |
added: verification-done-vivid removed: verification-needed-vivid |
Changed in lightdm (Ubuntu Wily): | |
assignee: | Robert Ancell (robert-ancell) → nobody |
This bug was fixed in the package lightdm - 1.15.1-0ubuntu1
---------------
lightdm (1.15.1-0ubuntu1) wily; urgency=medium
* New upstream release: tion. (LP: #1468057)
- Fix default X server command set to XMir in 1.15.0.
- Internally merge the [SeatDefaults] and [Seat:*] sections together. The
previous method meant configuration snippets using a mix of old and new
naming would not correctly override eachother.
- Use IP address of XDMCP requests to contact X server if available.
(LP: #1481561)
- Add an option for XDMCP and VNC servers to only listen on one address.
(LP: #1390808)
- Fix configuration file warnings so they go to the log, not stderr.
- Warn if deprecated options logind-load-seats or xdg-seat are in
configura
- Improve IP addresses in XDMCP log messages.
- Fix typo in dm-tool man page. (LP: #1470587)
-- Robert Ancell <email address hidden> Wed, 05 Aug 2015 16:53:39 +1200