Address bar doesn't support new TLDs
Bug #1441281 reported by
Riccardo Padovani
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
webbrowser-app |
Fix Released
|
Medium
|
Riccardo Padovani | |||
webbrowser-app (Ubuntu) | ||||||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
We have a function in `src/app/
It works well, but it checks tld length is <5.
TLD could be longer[0], so we should remove that restriction and find a better strategy to verify tld.
[0]: https:/
Related branches
lp://staging/~rpadovani/webbrowser-app/data-address
- Olivier Tilloy: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 77 lines (+15/-3)3 files modifiedsrc/app/webbrowser/AddressBar.qml (+1/-1)
src/app/webbrowser/urlManagement.js (+6/-1)
tests/unittests/qml/tst_AddressBar.qml (+8/-1)
Changed in webbrowser-app: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
description: | updated |
Changed in webbrowser-app: | |
status: | Confirmed → In Progress |
assignee: | nobody → Riccardo Padovani (rpadovani) |
summary: |
- Update looksLikeAUrl() function + Address bar doesn't support new TLDs |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
The best URL validator I had found is available at: /gist.github. com/dperini/ 729294
https:/
There is no size limit for TLD.