ListItem.Standard deprecated, but ListItem.ThinDivider not - two imports
Bug #1470951 reported by
Michał Karnicki
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Low
|
Unassigned | ||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
Perhaps the title of the bug could be worded differently, but I find it weird we deprecate ListItem.Standard and encourage use of ListItem component, but we don't move ListItem.
For the list item, you need Ubuntu.Components
For the list thin divider, you need Ubuntu.
Shouldn't this be somehow streamlined? You need two imports to:
1) create custom list items based on new ListItem
2) another one for a thin divider
Related branches
lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/deprecatedThinDivider
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu SDK team: Pending requested
-
Diff: 11 lines (+1/-0)1 file modifiedmodules/Ubuntu/Components/ListItems/1.3/ThinDivider.qml (+1/-0)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | Confirmed → Fix Committed |
To post a comment you must log in.
You don't actually need the old divider in the way you're suggesting. You're assuming there would be an equivalent new component when in fact the ListItem itself now provides it. I think we need to improve the documentation.
Example of a divider in the new API:
divider {
visible: true
colorFrom: UbuntuColors.red
colorTo: UbuntuColors.green
}
The colors are optional, it can be as simple as
divider.visible: action != actions[ actions. length - 1]
(In this example assuming an ActionSelection Popover where the delegate has an "action" and the model is a list of Action items)