defaultGridUnit unit test fails on hidpi screen
Bug #1457421 reported by
Cris Dywan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Cris Dywan | ||
| Vivid |
New
|
Undecided
|
Unassigned | ||
Bug Description
There's a test failure in tests/unit/
tst_units: FAIL! : tst_UCUnits:
tst_units: Actual (units.gridUnit()): 16
tst_units: Expected (8.0f) : 8
tst_units: Loc: [tst_units.cpp(36)]
My environment has the following setting
> echo $GRID_UNIT_PX
16
matching the 2x scale factor to accomodate my screen resolution.
I'm not sure why the default needs to be tested considering it's different on every device... it should either be dropped or the "units" test needs to clear the environment variable before testing it.
Related branches
lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/unsetGuBeforeDefaultCheck
- PS Jenkins bot: Approve (continuous-integration)
- Tim Peeters: Approve
-
Diff: 11 lines (+1/-0)1 file modifiedtests/unit/tst_units/tst_units.cpp (+1/-0)
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Christian Dywan (kalikiana) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1517+
---------------
ubuntu-ui-toolkit (1.3.1517+
[ Christian Dywan ]
* Expose textDocument of TextField. Fixes LP: #1392276
* Unset GRID_UNIT_PX before checking default value. Fixes LP: #1457421
* No cutting and copying of passwords. Fixes LP: #1438976
* Implement new API tool based on qmlplugindump producing JSON.
Fixes LP: #1187010
[ Leo Arias ]
* Make explicit the dependency on upstart for the autopilot helpers.
[ Timo Jyrinki ]
* uitk_test_plan.sh: Switch to vivid-overlay & wily instead of rtm-14.09 &
vivid. Fixes LP: #1457015.
-- CI Train Bot <email address hidden> Sat, 23 May 2015 17:24:43 +0000