[UbuntuShape] Contours and borders must be pixel-perfect under any resolution
Bug #1427253 reported by
Loïc Molinari
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Loïc Molinari | ||
| Vivid |
New
|
Undecided
|
Unassigned | ||
Bug Description
The UbuntuShape doesn't scale correctly at different resolution. The grid unit system implies that a fixed unit can have different pixel sizes on different form factors. The current rendering code uses simple bilinear filtering on a fixed texture size to display the borders, leading to magnification and minification artifacts (blurry borders). The shape is the base of all our UI components, it is visible on almost every applications using the toolkit, so it must be pixel-perfect under any resolution and scaling transforms.
Related branches
lp://staging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-resolution-independance
- Tim Peeters: Needs Fixing
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
- Timo Jyrinki: Approve (license)
- Michael Zanetti (community): Needs Fixing
- Florian Boucault: Pending requested
-
Diff: 9515 lines (+1764/-7091)15 files modifiedcomponents.api (+4/-1)
debian/copyright (+23/-0)
modules/Ubuntu/Components/plugin/shaders/shape.frag (+47/-11)
modules/Ubuntu/Components/plugin/shaders/shapeoverlay.frag (+48/-11)
modules/Ubuntu/Components/plugin/ucubuntushape.cpp (+309/-301)
modules/Ubuntu/Components/plugin/ucubuntushape.h (+37/-25)
modules/Ubuntu/Components/plugin/ucubuntushapeoverlay.cpp (+85/-176)
modules/Ubuntu/Components/plugin/ucubuntushapeoverlay.h (+2/-2)
modules/Ubuntu/Components/plugin/ucubuntushapetexture.h (+268/-6519)
modules/Ubuntu/Components/tools/3rd_party/edtaa3func.c (+570/-0)
modules/Ubuntu/Components/tools/createshapeimage.cpp (+231/-0)
modules/Ubuntu/Components/tools/shape.svg (+77/-0)
modules/Ubuntu/Components/tools/tools.pro (+5/-0)
tests/resources/ubuntushape/UbuntuShapeOverlayTest.qml (+44/-37)
tests/resources/ubuntushape/UbuntuShapeTest.qml (+14/-8)
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1510+
---------------
ubuntu-ui-toolkit (1.3.1510+
[ Loïc Molinari ]
* Set QSGNode debug description on the shape-based nodes to ease renderer
debugging. Fixes LP: #1437270
* Ensured QSGLayer-based source textures (like ShaderEffectSource) are
updated before rendering. Fixes LP: #1447495
[ Tim Peeters ]
* Update sections test program.
* Document the correct version when Page.head.visible and Page.head.locked
were added.
* Revert to use the old header in trunk.
* Introduce the new ActionBar component.
* Restore moving property on AppHeader 1.2.
[ Zsombor Egri ]
* Provide versioning for theme loading. Each toolkit must be released with a
well defined system theme version, and theme modules must have the same
version as the toolkit. Fixes LP: #1447113
* Fix import versions in entire UITK and examples. Move example code under
1.3 folder. Fixes LP: #1447113
* Separate 1.2 from 1.3 versions in all Ubuntu.Component modules.
Fixes LP: #1447113
[ Zoltan Balogh ]
* Fix header CPO for 1.2 without moving attribute. Let the header CPO try
both old and new buttons.
[ Christian Dywan ]
* Add version subfolder to benchmark test paths.
* Only show handlers if text isn't empty. Fixes LP: #1450213.
* Only print unique deprecation notes. Fixes LP: #1454281.
[ CI Train Bot ]
* New rebuild forced.
-- CI Train Bot <email address hidden> Tue, 19 May 2015 10:47:09 +0000