ActionSelectionPopover does not handle the 'visible' property of actions properly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Zoltan Balogh | ||
Ubuntu File Manager App |
Fix Released
|
Undecided
|
Niklas Wenzel | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Niklas Wenzel | ||
Vivid |
New
|
Undecided
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
Fix Released
|
Undecided
|
Niklas Wenzel |
Bug Description
When setting the 'visible' property of an action in an ActionList of an ActionSelection
Demo code (containing an outcommented workaround):
import QtQuick 2.3
import Ubuntu.Components 1.1
import Ubuntu.
import Ubuntu.
MainView {
width: units.gu(50)
height: units.gu(75)
Page {
title: i18n.tr(
Button {
id: button
width: parent.width
text: i18n.tr("Show popover")
}
}
Component {
id: actionSelection
}
// Uncomment the following for a temporary workaround:
// delegate: Empty {
// id: listItem
// Label {
// text: listItem.text
// anchors {
// verticalCenter: parent.
// horizontalCenter: parent.
// }
// wrapMode: Text.Wrap
// color: Theme.palette.
// }
// /*! \internal */
// onTriggered: popover.hide()
// visible: enabled && ((action === undefined) || action.visible)
// height: visible ? implicitHeight : 0
// }
}
}
}
}
Related branches
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 11 lines (+1/-1)1 file modifiedmodules/Ubuntu/Components/Popups/ActionSelectionPopover.qml (+1/-1)
- Zoltan Balogh: Approve
-
Diff: 11 lines (+1/-1)1 file modifiedmodules/Ubuntu/Components/Popups/ActionSelectionPopover.qml (+1/-1)
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Arto Jalkanen: Approve
-
Diff: 27 lines (+0/-17)1 file modifiedsrc/app/qml/ui/FolderListPage.qml (+0/-17)
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Niklas Wenzel (nikwen) |
no longer affects: | ubuntu-ui-toolkit |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
assignee: | nobody → Niklas Wenzel (nikwen) |
Changed in ubuntu-ui-toolkit (Ubuntu RTM): | |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
status: | Confirmed → In Progress |
milestone: | ww07-2015 → ww09-2015 |
assignee: | Niklas Wenzel (nikwen) → Zoltan Balogh (bzoltan) |
Changed in canonical-devices-system-image: | |
milestone: | ww09-2015 → ww13-ota |
status: | In Progress → Fix Released |
Changed in ubuntu-filemanager-app: | |
status: | New → In Progress |
Changed in ubuntu-filemanager-app: | |
status: | Fix Committed → Fix Released |
I just added the ubuntu- filemanager- app project to this bug report as that's where the issue first occured. It currently uses the workaround from the bug description and will remove it as soon as possible. /code.launchpad .net/~nikwen/ ubuntu- filemanager- app/zips/ +merge/ 239662
https:/